NavigationCallbacksTests fail when expecting navigation callbacks (ios_web_inttests) |
||||||
Issue descriptionNavifationCallbacksTests fail when expecting navigation callbacks. The affected tests are: UserInitiatedPostNavigation ReloadPostNavigation ForwardPostNavigation An example of a failure is available here: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/iphone9-device-x64/builds/11705/steps/ios_web_inttests%20%28iPhone%205s%20iOS%209.3.2%29%20on%20iOS-9.3.2/logs/stdio
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/80b9d5901a3f624a7c8ef8bd486cfcb532633172 commit 80b9d5901a3f624a7c8ef8bd486cfcb532633172 Author: peterlaurens <peterlaurens@chromium.org> Date: Mon Jun 05 18:12:06 2017 Disable failing navigation callbacks test. This disables tests that are causing NavigationCallbackTests to fail on device when running iOS 9.3. It's not trivial to revert the original change that introduced these tests as it has since been built upon. BUG= 729602 Review-Url: https://codereview.chromium.org/2920223003 Cr-Commit-Position: refs/heads/master@{#477032} [modify] https://crrev.com/80b9d5901a3f624a7c8ef8bd486cfcb532633172/ios/web/web_state/navigation_callbacks_inttest.mm
,
Jun 5 2017
,
Jun 6 2017
kkhorimoto@ Do you have any insight into why these tests are failing? From what I saw, the DidFinishNavigation and DidStopLoading calls weren't being called back for POST form submits. They were added by eugenebut@ in https://codereview.chromium.org/2903883002
,
Jun 6 2017
A couple of these tests are submitting forms via JavaScript; it might be possible that there's some latency involved on 9.3 where the callbacks are not received before the gmock EXPECTs are timed out. I'm not sure about UserInitiatedPostNavigation since there isn't a link to a test failure for that one, but it might be similar.
,
Jul 12 2017
,
Aug 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53548fd061b62911bb8329f7b31b92dfb82da167 commit 53548fd061b62911bb8329f7b31b92dfb82da167 Author: Eugene But <eugenebut@google.com> Date: Tue Aug 22 01:03:05 2017 Fixed NavigationCallbacksTest for iOS9 device. Use WaitForWebViewContainingText instead of ExecuteBlockAndWaitForLoad to wait for form submissions navigations. Bug: 729602 Change-Id: I872d83a4c32c616221bd103fa7befb2fda6ca478 Reviewed-on: https://chromium-review.googlesource.com/624068 Reviewed-by: Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#496147} [modify] https://crrev.com/53548fd061b62911bb8329f7b31b92dfb82da167/ios/web/web_state/navigation_callbacks_inttest.mm
,
Aug 22 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by peterlaurens@chromium.org
, Jun 5 2017