New issue
Advanced search Search tips

Issue 729597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Null-dereference READ in heap

Project Member Reported by ClusterFuzz, Jun 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4921300048150528

Fuzzer: mbarbella_js_mutation
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  heap
  GetHeap
  VerifyHeapPointer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=471691:471787

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4921300048150528


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: jkummerow@chromium.org
Owner: cbruni@chromium.org
Status: Assigned (was: Untriaged)
Reproduces in d8, local bisect isolates 3a80814d53ab706b61e5a862692a053b0bb04103.

Camillo, can you take a look please?
Labels: -Type-Bug Security_Impact-Head Security_Severity-High Restrict-View-SecurityTeam Type-Bug-Security
Looks security relevant, adding the respective labels.
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: M-60
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 6 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 7 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable

Comment 7 by cbruni@chromium.org, Jun 13 2017

This is merely a verification issue, since I forgot about constant tracking, fix on the way.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/66fe2d496d4f644cb20bdc8e5ceeae5b78776fbb

commit 66fe2d496d4f644cb20bdc8e5ceeae5b78776fbb
Author: Camillo Bruni <cbruni@chromium.org>
Date: Wed Jun 14 07:19:20 2017

[heap-verify] Relax arguments verification

For unknown Argument object Maps we have to expect that constants fields
are kept on the Map.

Bug:  chromium:729597 
Change-Id: I110f77455ce434a431c8de27d021b1a5deb86f30
Reviewed-on: https://chromium-review.googlesource.com/532900
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45935}
[modify] https://crrev.com/66fe2d496d4f644cb20bdc8e5ceeae5b78776fbb/src/objects-debug.cc
[add] https://crrev.com/66fe2d496d4f644cb20bdc8e5ceeae5b78776fbb/test/mjsunit/regress/regress-crbug-729597.js

Comment 9 by cbruni@chromium.org, Jun 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 19 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 11 by ClusterFuzz, Jun 20 2017

ClusterFuzz has detected this issue as fixed in range 479385:479423.

Detailed report: https://clusterfuzz.com/testcase?key=4921300048150528

Fuzzer: mbarbella_js_mutation
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  heap
  GetHeap
  VerifyHeapPointer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=471691:471787
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=479385:479423

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4921300048150528


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Jun 20 2017

ClusterFuzz has detected this issue as fixed in range 479385:479423.

Detailed report: https://clusterfuzz.com/testcase?key=4921300048150528

Fuzzer: mbarbella_js_mutation
Job Type: mac_asan_d8
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  heap
  GetHeap
  VerifyHeapPointer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=471691:471787
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_d8&range=479385:479423

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4921300048150528


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by sheriffbot@chromium.org, Jun 21 2017

Labels: Merge-Request-60
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 21 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
+awhalley does this need to be merge for M60?
Labels: -Security_Impact-Beta -ReleaseBlock-Stable
As per comment #7 this is not required.
Labels: -Merge-Review-60 Merge-Rejected-60
ok thanks!
Project Member

Comment 18 by sheriffbot@chromium.org, Sep 25 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment