New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729593 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jun 2017
Cc:
etienneb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Service Manager still leaking interface filters

Project Member Reported by roc...@chromium.org, Jun 5 2017 
This is a continuation of  issue 727830 . My patch was not sufficient to fix that, but I'm filing a separate bug for separate merge tracking. Proper fix incoming.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81e5ea73c5f350996f1d03a623098f0638a330cb

commit 81e5ea73c5f350996f1d03a623098f0638a330cb
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Jun 05 17:13:46 2017

Really fix Service Manager interface filter leaks

Move the important code from the destructor to the constructor, because,
well, it's not very useful in the destructor.

BUG= 729593 

Change-Id: I12e24839c936cd3bf37c9d2b73a721fd2ab59377
Reviewed-on: https://chromium-review.googlesource.com/524138
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477006}
[modify] https://crrev.com/81e5ea73c5f350996f1d03a623098f0638a330cb/services/service_manager/service_manager.cc

Comment 2 by roc...@chromium.org, Jun 5 2017

Labels: Merge-Request-60
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7ef4148b694826773a7c0dff0122e88df233c62

commit c7ef4148b694826773a7c0dff0122e88df233c62
Author: Ken Rockot <rockot@chromium.org>
Date: Tue Jun 06 17:22:37 2017

Really fix Service Manager interface filter leaks

Move the important code from the destructor to the constructor, because,
well, it's not very useful in the destructor.

BUG= 729593 
TBR=rockot@chromium.org

(cherry picked from commit 81e5ea73c5f350996f1d03a623098f0638a330cb)

Change-Id: I12e24839c936cd3bf37c9d2b73a721fd2ab59377
Reviewed-on: https://chromium-review.googlesource.com/524138
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477006}
Reviewed-on: https://chromium-review.googlesource.com/525999
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3112@{#188}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}
[modify] https://crrev.com/c7ef4148b694826773a7c0dff0122e88df233c62/services/service_manager/service_manager.cc
►

Sign in to add a comment