Eliminate IdentityAPI's usage of AccountTracker::FindAccountIdsByGaiaId() |
|||||
Issue descriptionAccountTracker is not a class that we want to expose via the Identity Service. As part of porting the identity extension API impl to use the Identity Service, we need to eliminate IdentityAPI calling AccountTracker::FindAccountIdsByGaiaId(). See the blocking bug for the discussion of how this elimination will occur, as it's intertwined with moving the identity extension API impl away from calling other synchronous signin methods.
,
Jun 6 2017
,
Jun 15 2017
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd8e7a2b81bcf21148850baf3cb77a299a1bc185 commit fd8e7a2b81bcf21148850baf3cb77a299a1bc185 Author: Colin Blundell <blundell@chromium.org> Date: Fri Jun 16 09:20:42 2017 Have Identity extension API impl find accountID via AccountTrackerService As crbug.com/729590 details, we are looking to eliminate AccountTracker entirely in favor of AccountTrackerService. As a step in that direction, this CL eliminates the one usage of AccountTracker::FindAccountIdsByGaiaId(), replacing it with equivalent usage of AccountTrackerService. It updates the corresponding browsertests to interact with AccountTrackerService rather than AccountTracker as well. Note that both AccountTracker and AccountTrackerService add an account in response to receiving OAuth2TokenService::OnRefreshTokenAvailable(), and both populate it with a GAIA ID in response to the user's info being fetched. Hence this change should be a no-op behaviorally. This CL also removes the now-unused function. Bug: 729590, 729582 Change-Id: Ideb1c4f0398d662ae6d0db04872474a52e3ef21d Reviewed-on: https://chromium-review.googlesource.com/535524 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#480001} [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/chrome/browser/extensions/api/identity/identity_api.cc [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/chrome/browser/extensions/api/identity/identity_api.h [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/chrome/browser/extensions/api/identity/identity_apitest.cc [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/google_apis/gaia/account_tracker.cc [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/google_apis/gaia/account_tracker.h [modify] https://crrev.com/fd8e7a2b81bcf21148850baf3cb77a299a1bc185/google_apis/gaia/account_tracker_unittest.cc
,
Sep 29 2017
,
Nov 7 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by blundell@chromium.org
, Jun 5 2017