New issue
Advanced search Search tips

Issue 729579 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

AppBannerManagerBrowserTest CheckOnLoadWithSufficientEngagement failing on unrelated code

Project Member Reported by ma...@chromium.org, Jun 5 2017

Issue description

It's a weird failure that only happened once so far but I thought I would document it. 

I checked with the settings prompt team and here is the reply:

"The issue happens when features in browser tests not are enabled in SetUpInProcessBrowserTestFixture()
We don't know exactly why it happens though...
This is how we do that: https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc?l=62"


https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60577

[ RUN      ] AppBannerManagerBrowserTest.CheckOnLoadWithSufficientEngagement
[5256:5668:0605/071834.269:INFO:media_foundation_video_encode_accelerator_win.cc(330)] Windows versions earlier than 8 are not supported.
[5472:4100:0605/071836.120:FATAL:settings_reset_prompt_config.cc(54)] Check failed: IsPromptEnabled().
Backtrace:
	base::debug::StackTrace::StackTrace [0x100ADE67+55]
	base::debug::StackTrace::StackTrace [0x100ADB01+17]
	logging::LogMessage::~LogMessage [0x1010210E+94]
	safe_browsing::SettingsResetPromptConfig::UrlToResetDomainId [0x04F6C124+148]
	safe_browsing::SettingsResetPromptModel::InitDefaultSearchData [0x04F702C7+279]
	safe_browsing::SettingsResetPromptModel::SettingsResetPromptModel [0x04F6F8A5+933]
	safe_browsing::SettingsResetPromptModel::OnSettingsFetched [0x04F70B9C+428]
	base::internal::FunctorTraits<void (__cdecl*)(Profile *,std::unique_ptr<safe_browsing::SettingsResetPromptConfig,std::default_delete<safe_browsing::SettingsResetPromptConfig> >,base::Callback<void __cdecl(std::unique_ptr<safe_browsing::SettingsResetPrompt [0x04F6EED8+72]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(Profile *,std::unique_ptr<safe_browsing::SettingsResetPromptConfig,std::default_delete<safe_browsing::SettingsResetPromptConfig> >,base::Callback<void __cdecl(std::unique_ptr<safe_brows [0x04F6F05B+75]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(Profile *,std::unique_ptr<safe_browsing::SettingsResetPromptConfig,std::default_delete<safe_browsing::SettingsResetPromptConfig> >,base::Callback<void __cdecl(std::unique_ptr<safe_browsing: [0x04F6F17A+138]
	base::internal::Invoker<base::internal::BindState<void (__cdecl*)(Profile *,std::unique_ptr<safe_browsing::SettingsResetPromptConfig,std::default_delete<safe_browsing::SettingsResetPromptConfig> >,base::Callback<void __cdecl(std::unique_ptr<safe_browsing: [0x04F714D1+49]
	base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSettings> >),1,1>::Run [0x04F690D3+67]
	base::internal::FunctorTraits<base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSettings> >),1,1>,void>::Invoke<base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_del [0x04F68910+160]
	base::internal::InvokeHelper<0,void>::MakeItSo<base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSettings> >),1,1>,std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSett [0x04F68982+34]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSettings> >),1,1>,base::internal::PassedWrapper<std::unique_ptr<BrandcodedDefaultSettings,std::def [0x04F689E9+57]
	base::internal::Invoker<base::internal::BindState<base::Callback<void __cdecl(std::unique_ptr<BrandcodedDefaultSettings,std::default_delete<BrandcodedDefaultSettings> >),1,1>,base::internal::PassedWrapper<std::unique_ptr<BrandcodedDefaultSettings,std::def [0x04F69126+54]
	base::Callback<void __cdecl(void),0,0>::Run [0x1004A305+53]
	base::debug::TaskAnnotator::RunTask [0x100B4DDC+476]
	base::MessageLoop::RunTask [0x10139A1C+508]
	base::MessageLoop::DeferOrRunPendingTask [0x10137E92+50]
	base::MessageLoop::DoWork [0x101384E2+274]
	base::MessagePumpForUI::DoRunLoop [0x10140253+67]
	base::MessagePumpWin::Run [0x101411EB+123]
	base::MessageLoop::Run [0x1013971F+191]
	base::RunLoop::Run [0x101F8D0A+186]
	content::RunThisRunLoop [0x02ACF52E+30]
	content::MessageLoopRunner::Run [0x02ACF0F2+162]
	content::TestNavigationObserver::Wait [0x02AF790C+28]
	ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete [0x0275BFDE+926]
	ui_test_utils::NavigateToURLWithDisposition [0x0275BC3A+26]
	ui_test_utils::NavigateToURL [0x0275BBF4+20]
	banners::AppBannerManagerBrowserTest::RunBannerTest [0x00686FA3+915]
	banners::AppBannerManagerBrowserTest_CheckOnLoadWithSufficientEngagement_Test::RunTestOnMainThread [0x00688095+165]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x02AE96FF+287]
	??$Invoke@PAVBrowserTestBase@content@@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x02AE72E2+18]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x02AE73B4+36]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x02AE75FB+59]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x02AE9924+36]
	base::Callback<void __cdecl(void),1,1>::Run [0x0061D421+33]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x02FB228B+5483]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x02FB0CC4+244]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x11A8E237+215]
	??$Invoke@PAVBrowserMainLoop@content@@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x11A834C2+18]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x11A838F4+36]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x11A83E7B+59]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x11A8E824+36]
	base::Callback<int __cdecl(void),1,1>::Run [0x127AA141+33]
	content::StartupTaskRunner::RunAllTasksNow [0x127ECB1B+107]
	content::BrowserMainLoop::CreateStartupTasks [0x11A8A4D9+569]
	content::BrowserMainRunnerImpl::Initialize [0x11A94485+981]
	content::BrowserMain [0x11A8070F+95]
	content::RunNamedProcessTypeMain [0x135A1F47+135]
	content::ContentMainRunnerImpl::Run [0x135A1DEC+572]
	content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x1359FBC4+36]
	service_manager::Main [0x0FAF8809+777]
	content::ContentMain [0x135A00B9+41]
	content::BrowserTestBase::SetUp [0x02AE9E4C+1212]
	InProcessBrowserTest::SetUp [0x02756CC5+741]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x01508454+52]
	testing::Test::Run [0x0151DB3D+77]
	testing::TestInfo::Run [0x0151DD8D+173]
	testing::TestCase::Run [0x0151DC6F+191]

 
That's.... odd. Haven't run into this before.

It's less than ideal to move the feature setup to SetUpInProcessBrowserTestFixture because it's only needed for a couple of tests. Additionally, there are lots of other tests which only enable features in the test itself rather than in a setup method (I just touched some notifications interactive UI tests that did this too).
Just see this issue, it seems we need to enable kSettingsResetPrompt 
 in ctor with scoped_feature_list. 

https://cs.chromium.org/chromium/src/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_config.cc?rcl=d21041d4d1342713aba41f8474cf7cff3647e05b&l=28
Status: WontFix (was: Assigned)
WontFixing for lack of reproducibility. Please re-open if it crops up again. :)

Sign in to add a comment