New issue
Advanced search Search tips

Issue 729563 link

Starred by 1 user
Status: Fixed
Owner:
jorgelo@chromium.org
Closed: Feb 2018
Cc:
keescook@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

security_x86Registers: print a better TEST_NA message with chipset info

Project Member Reported by jorgelo@chromium.org, Jun 5 2017 
I see the following output on wmatrix:

security_x86Registers	R61-9611.0.0-rc1	samus	
Unsupported CPU: x86_64

Is this correct? Does this need to be fixed? Or is security_x86Registers meant specifically for ia32?

Assigned to Kees to answer the question, not to eventually fix the test.

Comment 1 by keescook@chromium.org, Jun 5 2017

Cc: keescook@chromium.org
Owner: jorgelo@chromium.org
x86Registers supports earlier x86_64 chipsets. At some point, the mechanism for checking firmware lockdown changed for newer chipsets, and, IIRC, checking it can be tricky, so the implementations have been ignored for this test.

The test reports architecture instead of chipset when it fails to run (that could be improved, something like "x86_64 chipset xxxx:xxxx unknown" etc.

Comment 2 by jorgelo@chromium.org, Jun 6 2017 

Yeah, we should probably print something clearer. I can own that.

Comment 3 by jorgelo@chromium.org, Jun 6 2017

Summary: security_x86Registers: print a better TEST_NA message with chipset info (was: Should security_x86Registers work for x86_64?)

Comment 4 by jorgelo@chromium.org, Aug 1 2017

Components: OS>Systems
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/57a1d29811a35ba4b020b2e006cbd940adc93df4

commit 57a1d29811a35ba4b020b2e006cbd940adc93df4
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Sat Feb 24 05:06:36 2018

security_x86Registers: Update messages.

The existing message is confusing. It would print:

"Unsupported CPU: x86_64"

which is not really true. Update to better reflect that the CPU is
unknown rather than unsupported.

BUG= chromium:729563 
TEST=Passes on caroline with dependency.
CQ-DEPEND=CL:934781

Change-Id: I0b66739d7f37d04f3be8afcb9373d9882f50435e
Reviewed-on: https://chromium-review.googlesource.com/934682
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>

[modify] https://crrev.com/57a1d29811a35ba4b020b2e006cbd940adc93df4/client/site_tests/security_x86Registers/security_x86Registers.py
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9f3bae7570f4b7d6bc4b83b0badbdab5280280be

commit 9f3bae7570f4b7d6bc4b83b0badbdab5280280be
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Sat Feb 24 05:06:34 2018

power_utils: Add Core M regex.

We have a bunch of Core M systems.

BUG= chromium:729563 
TEST=security_x86Registers now passes on caroline (Core m3).

Change-Id: I00b1a00e7cfd3bda505cf70fbe7f28ed65f87bf3
Reviewed-on: https://chromium-review.googlesource.com/934781
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/9f3bae7570f4b7d6bc4b83b0badbdab5280280be/client/cros/power/power_utils.py

Comment 7 by jorgelo@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment