New issue
Advanced search Search tips

Issue 729561 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge privacy requirements for the Budget API to M60

Project Member Reported by peter@chromium.org, Jun 5 2017

Issue description

The privacy issue is restricted so I presume the approval bot cannot see it. Let's try a separate issue.


The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c993f78366636eb3b4b4f0a3749a52862c96ee5

commit 9c993f78366636eb3b4b4f0a3749a52862c96ee5
Author: peter <peter@chromium.org>
Date: Fri Jun 02 21:47:42 2017

Return empty Budget API buckets if there is no notification permission

This change only affects the GetBudget() method that we're
experimenting with as part of an Origin Trial.

BUG=710809

Review-Url: https://codereview.chromium.org/2915173002
Cr-Commit-Position: refs/heads/master@{#476804}

[modify] https://crrev.com/9c993f78366636eb3b4b4f0a3749a52862c96ee5/chrome/browser/budget_service/budget_manager_browsertest.cc
[modify] https://crrev.com/9c993f78366636eb3b4b4f0a3749a52862c96ee5/chrome/browser/budget_service/budget_service_impl.cc
 

Comment 1 by peter@chromium.org, Jun 5 2017

Labels: Merge-Request-60

Comment 2 by peter@chromium.org, Jun 5 2017

Labels: -OS-All OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by peter@chromium.org, Jun 6 2017

Labels: -Merge-Approved-60 merge-merged-3112
Status: Fixed (was: Started)
Merged here:

https://chromium.googlesource.com/chromium/src.git/+/0c3ae1eeef6f00e04506519e05cc6d4c6fee532f

Sign in to add a comment