New issue
Advanced search Search tips

Issue 729551 link

Starred by 1 user
Status: Duplicate
Merged: issue 728682
Owner:
cbruni@chromium.org
Closed: Jun 2017
Cc:
jarin@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5%-29.6% regression in v8.runtimestats.browsing_desktop at 475361:475427

Project Member Reported by jarin@google.com, Jun 5 2017 
Could you take a look, please?

The only CL in that range that touches runtime related stuff is

e822488 [runtime] Directly support double values in CloneShallowObjectLiteral.

Comment 1 by jarin@google.com, Jun 5 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=729551

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgho6EsggM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxtj49AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsr-vwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvjxtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoi89AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghoj60AsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghr_U-AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqOdrAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghsbCxgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuXE8gkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsWT_AkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghp3ElQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuWS6wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgpujXpQsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgpvqe9goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxqDpoQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxoTUswoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsiylwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpGP5wkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpycowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxo6kvwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxsm8vgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDght_89wgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghr_5rQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxpjMvwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghpP1pgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghv3-6goM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghuOj7AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxszK9QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghr_jvAkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-sOu8QkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxrTHtAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgxvSlqwsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-s2IqgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqWc-AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghtnTvQgM


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus6
android-nexus7v2
android-webview-nexus6
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win8-dual
linux-release
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jun 5 2017

Mergedinto: 728682
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Camillo Bruni
  Commit : e822488d76755d9fdb9938adb01c90428f5b7131
  Date   : Mon May 29 13:27:17 2017
  Subject: [runtime] Directly support double values in CloneShallowObjectLiteral

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : v8.runtimestats.browsing_desktop
  Metric       : IC:duration_avg/browse_news/browse_news_flipboard
  Change       : 32.00% | 349.664 -> 461.548333333

Revision                           Result                  N
chromium@475360                    349.664 +- 11.5651      6      good
chromium@475379                    357.289 +- 24.3663      6      good
chromium@475388                    378.359 +- 48.0421      6      good
chromium@475388,v8@2ba1fcda5f      365.694 +- 39.8127      6      good
chromium@475388,v8@74681db644      365.91 +- 38.3716       6      good
chromium@475388,v8@e822488d76      451.426 +- 44.3972      6      bad       <--
chromium@475388,v8@8f7af5fb13      464.46 +- 56.7331       6      bad
chromium@475389                    447.386 +- 41.9232      6      bad
chromium@475390                    458.59 +- 33.785        6      bad
chromium@475391                    456.748 +- 72.307       6      bad
chromium@475393                    458.467 +- 88.3737      6      bad
chromium@475397                    461.548 +- 75.3035      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.flipboard v8.runtimestats.browsing_desktop

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977622421477248256

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5802261185298432


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
►

Sign in to add a comment