New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729527 link

Starred by 1 user
Status: Fixed
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: [DevTools] 'Run audit' and 'Cancel' button are not seen on 'Audits' to perform overlay.

Reported by dchau...@etouch.net, Jun 5 2017 
Chrome Version: 61.0.3119.0 (Official Build) (64-bit)177b9b934d8398dfb0d17b88fd9ff00f3291cca5-refs/heads/master@{#476838} 32/64-bit.
OS: Windows(7,8,8.1), Linux(14.04 LTS), Mac(10.11.6, 10.12.3)

What steps will reproduce the problem?
1. Launch chrome, open 5-6 NTP, open 'DevTools' and dock it to bottom.
2. Go to 'Audits' section and click on 'Perform and audit' button.
3. Now, observe the 'Run audit' and 'Cancel' button 'Audits' to perform overlay. 

'Run audit' and 'Cancel' button are not seen on 'Audits' to perform overlay.
'Run audit' and 'Cancel' button should seen on 'Audits' to perform overlay.

This is a regression issue, broken in M-60 series, below is manual regression range.

Good build: 60.0.3109.0
Bad build: 60.0.3110.0

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
1.4 MB View Download

Comment 1 by rbasuvula@chromium.org, Jun 5 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: phulce@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3109.0 (Revision:474118).
Bad build:60.0.3110.0 (Revision:474499).

You are probably looking for a change made after 474157 (known good), but no later than 474158 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/43017673005af77aba9dc160a4c1ee4ee47076ff..23da751ab184c42ed88c67e150c316878105211e

From the CL above, assigning the issue to the concern owner

@phulce: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2901133002
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3119.0
Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 2 by phulce@chromium.org, Jun 6 2017

Labels: -Pri-1 -ReleaseBlock-Stable -Type-Bug-Regression Pri-2 Type-Bug
I wouldn't label this as a ReleaseBlock regression since the exact issue was pre-existing on smaller screen sizes. It is definitely very poor UX that the rest of the UI is frozen until the modal is closed with no visible action buttons though.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b110912c4c3ddb957ca40eca187632a443776156

commit b110912c4c3ddb957ca40eca187632a443776156
Author: Patrick Hulce <phulce@chromium.org>
Date: Wed Jun 07 23:51:04 2017

DevTools: Add close button to Audits2 dialog

BUG= 729527 

Change-Id: Ie70e021546c41a2ebd6d8a6769796fd5093ce886
Reviewed-on: https://chromium-review.googlesource.com/526375
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477808}
[modify] https://crrev.com/b110912c4c3ddb957ca40eca187632a443776156/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/b110912c4c3ddb957ca40eca187632a443776156/third_party/WebKit/Source/devtools/front_end/audits2/audits2Dialog.css

Comment 4 by phulce@chromium.org, Jun 8 2017

Status: Fixed (was: Assigned)
While those buttons still won't be visible on smaller viewports, the user now has an alternative action button to close the dialog.
►

Sign in to add a comment