New issue
Advanced search Search tips

Issue 729525 link

Starred by 11 users
Status: Fixed
Owner: ----
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Consider providing auth credentials over DevToolsProtocol.

Project Member Reported by alexclarke@chromium.org, Jun 5 2017 
When Network request interception is turned on and we intercept a 401 or 407 it would be possible to provide auth credentials over DevTools Protocol.

To do this we'd need:

* A new Network domain event sent via DevToolsURLInterceptorRequestJob::OnAuthRequired which will contain the details from net::AuthChallengeInfo.
* A new Network domain command which based on calling params will either call SetAuth (with a user name & password) call CancelAuth, or rely on the URLRequestJob's delegate (like the code currently does).

Comment 1 by alexclarke@chromium.org, Jun 5 2017

Labels: Proj-Headless

Comment 2 by alexclarke@chromium.org, Jun 5 2017

Components: Internals>Headless
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4640aeaa9e5e64220d4344e619d6d3ab92023df1

commit 4640aeaa9e5e64220d4344e619d6d3ab92023df1
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Jun 16 10:01:07 2017

Allow Auth Credentials to be passed over DevTools protocol

When Network request interception is turned on and we intercept a 401 or 407
we now give the protocol user a chance to either provide the credentials,
cancel the auth request, or fall back to the default implementation (likely
canceling the auth, or possibly displaying a dialog box).

Bug:  729525 ,  702384 
Change-Id: I8e7c92a0f44a07a30767a2f2076b0feb1c9c2bed
Reviewed-on: https://chromium-review.googlesource.com/535695
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480005}
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol_config.json
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-cancel-expected.txt
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-cancel.html
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-provide-credentials-expected.txt
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-provide-credentials.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/.htaccess
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/iframe-auth-js.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/unauthorised.pl
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail-expected.txt
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/Source/core/inspector/browser_protocol.json

Comment 4 by alexclarke@chromium.org, Jun 16 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment