Issue metadata
Sign in to add a comment
|
Regression: Unwanted focus is seen in options link of translate bubble |
||||||||||||||||||||||
Issue descriptionChrome Version: 61.0.3119.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1)Launch chrome and go to http://www.jd.com/ >> Let the page gets loaded, observe focus on options icon (2)Now click somewhere outside so that bubble closes, Now again click on translate bubble and observe dotted border[focus] on translate bubble Expected: No such focus should be seen on options link. Actual: Instead unwanted border is seen on options link. NOTE: If it is intended to have initial focus on options link, then options link should be highlighted for first time as well. i.e; For first time focus is on translate button and from second opening of bubble it is on options link. This is a regression issue broken in M60. Good Build: 60.0.3073.0 dev Bad Build: 60.0.3074.0 dev
,
Jun 5 2017
Using per revision bisect providing information below. Bisect Information: -------------------- You are probably looking for a change made after 465074 (known good), but no later than 465075 (first known bad). Change Log URL: https://chromium.googlesource.com/chromium/src/+log/5253666c1cbd892f7c74ee0c2c207df2e5bdc9a8..daaea2c2c745c2f0983de26d7b812d34622773b4 From the above change log suspecting below change Review URL: https://codereview.chromium.org/2827433005 ftang@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Jul 13 2017
,
Jul 26 2017
There are two issues here: 1. When the bubble UI is shown for the first time in a tab the bubble does not have focus (focus remains with the page content). 2. When the bubble UI is show subsequent times in the tab the "options" link has focus. My feeling is that the correct behaviour is: 1. Every time the bubble UI is shown (first, second, etc.) "Translate" should have focus. Yana, can you give some direction what the correct behaviour should be here?
,
Jul 26 2017
Not focusing the bubble on show is intentional. Since the bubble can appear not in direct response to a user action, taking focus can be incredibly frustrating ("focus stealing"). I would be very wary of changing that, as it was one of the most discussed parts of the bubble UI when we replaced the old infobar-based UI.
,
Jul 26 2017
I think the right long term solution is to not have focus on the "options" link. I am not sure if the focus on it was intentional or not: I can imagine the logic that would explain having it there after the second time would be to encourage the user to change their Settings if they hide the UI and open it again but that seems to not make a ton of sense. I am not too concerned about leaving it as is for the time being if the fix is lengthy since we'll be building a new UI anyways.
,
Nov 14 2017
,
Jan 18 2018
,
Jan 30 2018
There is no longer an Options link in 65+ due to work on crbug.com/730521 so closing this as no longer applicable |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Jun 5 2017