New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729503 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification



Sign in to add a comment

Remove URLLoaderFactory usage in browser-side case

Project Member Reported by kinuko@chromium.org, Jun 5 2017

Issue description

Remove URLLoaderFactory usage in browser-side case: for navigation we don't need mojo URLLoaderFactory calls and directly creating URLLoader is suffice.

In the case we probably want to have URLLoader::Start method so that we can start a loader withour URLLoaderFactory.
 
Split out from  issue 724322 

Comment 2 by jam@chromium.org, Jun 5 2017

Can you elaborate more on why we need URLLoaderStart? i.e. is it not sufficient that the C++ interface creates URLLoader implementations that are started?
My understanding is that URLLoader may comes from the network service or somewhere in the browser. It would convenient to have a consistent way to start it. For example, ThrottlingURLLoader controls whether/when to start a request. It is inconvenient if it has to know about the different ways of starting a request.

Comment 4 by jam@chromium.org, Jun 5 2017

Can't we assume that whoever provides a URLLoader in the browser returns it started?
I think we could do that, too. Just trying to say that in that case, whoever needs to control when to start a request may need to either (1) know about the difference between URLLoaderFactory and the browser-side C++ interface; or (2) hide that difference behind another C++ interface.

And *not* adding URLLoader::Start avoids adding one more IPC, which is nice.
We have another example where we want to get a non-started loader, so having Start on URLLoader feels certainly handier / consistent.  We could try the other way too, let's see which way we like.
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017

Owner: kinuko@chromium.org
Status: Fixed (was: Started)
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment