Issue metadata
Sign in to add a comment
|
Remove URLLoaderFactory usage in browser-side case |
||||||||||||||||||||||||
Issue descriptionRemove URLLoaderFactory usage in browser-side case: for navigation we don't need mojo URLLoaderFactory calls and directly creating URLLoader is suffice. In the case we probably want to have URLLoader::Start method so that we can start a loader withour URLLoaderFactory.
,
Jun 5 2017
Can you elaborate more on why we need URLLoaderStart? i.e. is it not sufficient that the C++ interface creates URLLoader implementations that are started?
,
Jun 5 2017
My understanding is that URLLoader may comes from the network service or somewhere in the browser. It would convenient to have a consistent way to start it. For example, ThrottlingURLLoader controls whether/when to start a request. It is inconvenient if it has to know about the different ways of starting a request.
,
Jun 5 2017
Can't we assume that whoever provides a URLLoader in the browser returns it started?
,
Jun 5 2017
I think we could do that, too. Just trying to say that in that case, whoever needs to control when to start a request may need to either (1) know about the difference between URLLoaderFactory and the browser-side C++ interface; or (2) hide that difference behind another C++ interface. And *not* adding URLLoader::Start avoids adding one more IPC, which is nice.
,
Jun 6 2017
We have another example where we want to get a non-started loader, so having Start on URLLoader feels certainly handier / consistent. We could try the other way too, let's see which way we like.
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8b13e21c0c676d7f8e075236948983d09b42bbe commit d8b13e21c0c676d7f8e075236948983d09b42bbe Author: kinuko <kinuko@chromium.org> Date: Wed Jun 07 06:59:26 2017 Get rid of URLLoaderFactory in browser-side case BUG= 729503 Review-Url: https://codereview.chromium.org/2919313004 Cr-Commit-Position: refs/heads/master@{#477568} [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/loader/navigation_url_loader_network_service.cc [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/loader/url_loader_request_handler.h [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_controllee_request_handler.cc [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_controllee_request_handler.h [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_request_handler.cc [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_request_handler.h [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_url_job_wrapper.cc [modify] https://crrev.com/d8b13e21c0c676d7f8e075236948983d09b42bbe/content/browser/service_worker/service_worker_url_job_wrapper.h
,
Jun 7 2017
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acde73a7fa15b3877a342ddd8c5d71e97f070aa8 commit acde73a7fa15b3877a342ddd8c5d71e97f070aa8 Author: kinuko <kinuko@chromium.org> Date: Thu Jun 08 04:41:50 2017 Use independent URLLoader in browser-side code BUG= 729503 Review-Url: https://codereview.chromium.org/2931623002 Cr-Commit-Position: refs/heads/master@{#477890} [modify] https://crrev.com/acde73a7fa15b3877a342ddd8c5d71e97f070aa8/content/browser/loader/navigation_url_loader_network_service.cc [modify] https://crrev.com/acde73a7fa15b3877a342ddd8c5d71e97f070aa8/content/browser/loader/navigation_url_loader_network_service.h [modify] https://crrev.com/acde73a7fa15b3877a342ddd8c5d71e97f070aa8/content/browser/loader/url_loader_request_handler.h [modify] https://crrev.com/acde73a7fa15b3877a342ddd8c5d71e97f070aa8/content/browser/service_worker/service_worker_url_job_wrapper.cc
,
Jun 8 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kinuko@chromium.org
, Jun 5 2017