Copied from https://chromium-review.googlesource.com/c/522503/1/third_party/WebKit/Source/modules/ModulesInitializer.cpp#107 "I think we want reasonably well-defined, similarly looking interfaces for WorkerClients set-up for various workers. This should be named something like RegisterWorkerClientsProviderCallback. (Hiroki- maybe we could provide something for these in worker infra?)"
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48 commit 6bcbd1909239bf92cd08cfe9f33a16a8a6061d48 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Jun 12 14:34:12 2017 Worker: Merge WebWorkerContentSettingsClientProxy into WebContentSettingsClient As a cleanup, this CL... - merges WebWorkerContentSettingsClient into WebContentSettingsClient, - renames WebWorkerContentSettingsClientProxy into WebWorkerContentSettingsClient, and - makes CreateWorkerContentSettingsClient() return std::unique_ptr instead of a rawptr w/ ownership. Bug: 729500 Change-Id: Icc7b9f26f52f3312c16c36b356d2cf9c34b5a99a Reviewed-on: https://chromium-review.googlesource.com/527763 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#478614} [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/chrome/renderer/BUILD.gn [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/chrome/renderer/chrome_content_renderer_client.h [rename] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/chrome/renderer/worker_content_settings_client.cc [add] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/chrome/renderer/worker_content_settings_client.h [delete] https://crrev.com/221f04f1ef2f889bd8452f1d0435f953b6c997ee/chrome/renderer/worker_content_settings_client_proxy.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/public/renderer/content_renderer_client.cc [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/public/renderer/content_renderer_client.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/render_frame_impl.cc [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/render_frame_impl.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.cc [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/shared_worker/embedded_shared_worker_content_settings_client_proxy.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/core/workers/WorkerContentSettingsClient.cpp [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/core/workers/WorkerContentSettingsClient.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/modules/ModulesInitializer.cpp [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/public/web/WebEmbeddedWorker.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/public/web/WebFrameClient.h [modify] https://crrev.com/6bcbd1909239bf92cd08cfe9f33a16a8a6061d48/third_party/WebKit/public/web/WebSharedWorkerClient.h [delete] https://crrev.com/221f04f1ef2f889bd8452f1d0435f953b6c997ee/third_party/WebKit/public/web/WebWorkerContentSettingsClientProxy.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0360525b2aa909a241c9d4cbb4602160c8d8aff5 commit 0360525b2aa909a241c9d4cbb4602160c8d8aff5 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Jun 16 14:44:28 2017 Worker: Introduce a unified way to provide module clients to WorkerClients As a code cleanup, this CL introduces WorkerClientsInitializer that enables each module (e.g. IndexedDB) to provide its client to WorkerClients (in core/workers/) for various workers in a unified way. Before this CL, such provisioning code were scattered over the codebase and some worker needed to implement an intermediate layer (in web/) to jump over the module boundary. Bug: 729500 Change-Id: I07b31c5dd8eaeb1efb54384c20e2d2bf1e008ef6 Reviewed-on: https://chromium-review.googlesource.com/532481 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#480040} [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/workers/BUILD.gn [delete] https://crrev.com/161fcad68806b0b75502648c8f1e2e83d6bc33bd/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp [delete] https://crrev.com/161fcad68806b0b75502648c8f1e2e83d6bc33bd/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/workers/Worker.cpp [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/workers/Worker.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/core/workers/WorkerClients.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/modules/ModulesInitializer.cpp [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/web/BUILD.gn [delete] https://crrev.com/161fcad68806b0b75502648c8f1e2e83d6bc33bd/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp [delete] https://crrev.com/161fcad68806b0b75502648c8f1e2e83d6bc33bd/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/public/web/WebEmbeddedWorker.h [modify] https://crrev.com/0360525b2aa909a241c9d4cbb4602160c8d8aff5/third_party/WebKit/public/web/WebSharedWorker.h
Comment 1 by nhiroki@chromium.org
, Jun 8 2017Status: Assigned (was: Available)