New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729443 link

Starred by 1 user
Status: Fixed
Owner:
█ tibell@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
Proj-Servicification



Sign in to add a comment

Wait for the persistent pref store to be initialized before returning from factory

Project Member Reported by tibell@chromium.org, Jun 5 2017 
The prefs::ConnectToPrefService factory function sometimes returns a PrefService object that's not yet fully initialized (i.e. PrefService::GetInitializationStatus returns INITIALIZATION_STATUS_WAITING). Since we're already using a callback to wait for the connection to the service we might as well wait for the object to be initialized as well, simplifying things for clients.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4430857991cdb2b974bd99c565ff8713b48e3ad

commit a4430857991cdb2b974bd99c565ff8713b48e3ad
Author: Johan Tibell <tibell@chromium.org>
Date: Mon Jun 05 07:09:53 2017

pref service: simplify client connection API

The client no longer needs to wait for the returned PrefService object
to be initialized.

Bug:  729443 
Change-Id: I41ab70610c043a022ead8ad33db32359f2d28f48
Reviewed-on: https://chromium-review.googlesource.com/523364
Commit-Queue: Johan Tibell <tibell@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476956}
[modify] https://crrev.com/a4430857991cdb2b974bd99c565ff8713b48e3ad/services/preferences/pref_service_factory_unittest.cc
[modify] https://crrev.com/a4430857991cdb2b974bd99c565ff8713b48e3ad/services/preferences/public/cpp/pref_service_factory.cc

Comment 2 by tibell@chromium.org, Jun 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment