Issue metadata
Sign in to add a comment
|
Chrome's Task Manager doesn't remember size and position after closing.
Reported by
heat...@gmail.com,
Jun 4 2017
|
||||||||||||||||||||||
Issue description
Chrome Version : 59.0.3071.82
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:
What steps will reproduce the problem?
1. Open Task Manager and change window size/position then close it.
2. Reopen Task Manager and it has resetted size/position to default.
3.
What is the expected result?
To remember Task Manager's window size and position after closing.
What happens instead of that?
It opens with default window size and position.
Please provide any additional information below. Attach a screenshot if
possible.
UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.82 Safari/537.36
,
Jun 6 2017
Able to reproduce this issue on Windows-10 and Ubuntu 14.04 using chrome latest beta #59.0.3071.82. This issue is not observed on Mac OS 10.12. As per the bisect info provided in the comment #1 assigning to the concerned person for more updates. thomasanderson@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e3beeadb7a48af2c3dd58e0ec22085fc988636b commit 2e3beeadb7a48af2c3dd58e0ec22085fc988636b Author: thomasanderson <thomasanderson@chromium.org> Date: Thu Jun 08 03:26:12 2017 Linux Aura: Use Separate profile key specifically for theme usage This CL is a revert to patch set 1 of CL [1]. This is necessary because window position save/restore for the task manager relies on the regular profile key being null for the task manager widget. [1] https://codereview.chromium.org/2862113002/#ps1 BUG= 729405 R=sky@chromium.org Review-Url: https://codereview.chromium.org/2923323002 Cr-Commit-Position: refs/heads/master@{#477872} [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/views/native_widget_factory.cc [add] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/views/theme_profile_key.cc [add] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/chrome/browser/ui/views/theme_profile_key.h [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/2e3beeadb7a48af2c3dd58e0ec22085fc988636b/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
,
Jun 8 2017
,
Jun 9 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88bf0989418d6a9aee2e4f9de2ae0015181ff081 commit 88bf0989418d6a9aee2e4f9de2ae0015181ff081 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Jun 09 18:03:27 2017 [Merge to M60] Linux Aura: Use Separate profile key specifically for theme usage > This CL is a revert to patch set 1 of CL [1]. This is necessary > because window position save/restore for the task manager relies on > the regular profile key being null for the task manager widget. > > [1] https://codereview.chromium.org/2862113002/#ps1 > > BUG= 729405 > R=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2923323002 > Cr-Commit-Position: refs/heads/master@{#477872} BUG= 729405 TBR=sky@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2928803006 . Cr-Commit-Position: refs/branch-heads/3112@{#286} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/views/native_widget_factory.cc [add] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/views/theme_profile_key.cc [add] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/chrome/browser/ui/views/theme_profile_key.h [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/88bf0989418d6a9aee2e4f9de2ae0015181ff081/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
,
Jun 9 2017
,
Jun 13 2017
,
Jun 14 2017
Verified the issue on windows 10 and Ubuntu 14.04 using chrome beta version #60.0.3112.32 as per comment #0 Observed that chrome's Task Manager remembered window size and position after closing. Hence, the fix is working as expected. Attaching screen cast for reference. Hence, adding the verified labels. Thanks...!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by woxxom@gmail.com
, Jun 4 2017