New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729403 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

CSS.supports(one_string) should accept paren-less declaration

Project Member Reported by eco...@igalia.com, Jun 4 2017

Issue description

See http://software.hixie.ch/utilities/js/live-dom-viewer/saved/4881

Expected result: true, true
Actual result: true, false

Relevant spec: https://drafts.csswg.org/css-conditional/#the-css-interface

> When invoked with a single conditionText argument, it must return true if conditionText, when either parsed and evaluated as a supports_condition or parsed as a declaration, wrapped in implied parentheses, and evaluated as a supports_condition, would return true. Otherwise, it must return false.

(Note the "wrapped in implied parentheses").

Gecko is fixing at https://bugzilla.mozilla.org/show_bug.cgi?id=1338486.
 
Labels: Hotlist-Interop
Labels: Update-Quarterly
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5416b84aba8ec3442788d6bbea54091ef18b6b0

commit b5416b84aba8ec3442788d6bbea54091ef18b6b0
Author: ecobos <ecobos@igalia.com>
Date: Tue Jun 06 12:03:07 2017

[css-conditional] CSS.supports with one string should accept paren-less declaration.

Relevant spec: https://drafts.csswg.org/css-conditional/#the-css-interface

> When invoked with a single conditionText argument, it must return true if
> conditionText, when either parsed and evaluated as a supports_condition or
> parsed as a declaration, wrapped in implied parentheses, and evaluated as a
> supports_condition, would return true. Otherwise, it must return false.

(Note the "wrapped in implied parentheses").

BUG= 729403 

Review-Url: https://codereview.chromium.org/2919283002
Cr-Commit-Position: refs/heads/master@{#477264}

[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/LayoutTests/css3/supports-dom-api-expected.txt
[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/LayoutTests/css3/supports-dom-api.html
[delete] https://crrev.com/1fb6007f25ce38b50bd6700f292e65ca8e501e7b/third_party/WebKit/LayoutTests/external/wpt/cssom/CSS-expected.txt
[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/Source/core/css/parser/CSSParser.cpp
[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp
[modify] https://crrev.com/b5416b84aba8ec3442788d6bbea54091ef18b6b0/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.h

Comment 4 by eco...@igalia.com, Jun 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment