New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729363 link

Starred by 4 users

Issue metadata

Status: Fixed
Merged: issue 682074
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 630357



Sign in to add a comment

Dialog paint disappears when hovering over buttons

Project Member Reported by bettes@chromium.org, Jun 3 2017

Issue description

Version 61.0.3119.0
Mac

What steps will reproduce the problem?
(1) Open any chrome dialog, e.g. bookmarks or OIB
(2) Hover over a button 
(3) Dialog paint will disappear, but button functionality and appearance will remain



 
dialog.mov
570 KB Download
oib.mov
5.8 MB Download
image (31).png
21.3 KB View Download
Labels: OS-Mac
Cc: danakj@chromium.org wkorman@chromium.org sky@chromium.org
Labels: OS-Windows
I haven't been able to reproduce this on Mac yet (tried up to 61.0.3119.0), but I managed to repro on Windows in a browser_tests build (at r476210 - 61.0.3118.0) - see attached.

browser_tests.exe --dialog=BookmarkBubbleViewBrowserTest.InvokeDialog_bookmark_details --gtest_filter=BrowserDialogTest.Invoke --interactive --enable-pixel-output-in-tests --secondary-ui-md

It seems that as soon as a Layer is made invisible, the root canvas is cleared. The Layer can be the one we now use for the text input cursor/ibeam, or an InkDrop layer on MD buttons (so with the former, --secondary-ui-md isn't needed to repro this).
badpaint_win.mov
382 KB Download
(inline video.. finally figured out how to do this on mac..)
badpaint_win.mp4
497 KB View Download
Cc: bruthig@chromium.org
Labels: -Pri-2 Pri-1
+CC bruthig who worked with layers when adding InkDrop stuff.
OK I found the magic combo. With:

--disable-gpu --disable-gpu-rasterization

This reproduces for me reliably on Windows official build for 61.0.3119.0.
Labels: -Type-Bug M-60 Type-Bug-Regression
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
You are probably looking for a change made after 470979 (known good), but no later than 470991 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/1852efa6e4d9c3353cd43d1815929d46e0f19a70..67fdcd138ad6a6a8c27848b668355f8c571a89a1

Suspect
Avoid using SkClipOp::kReplace_deprecated in software renderer - r470981 -> https://codereview.chromium.org/2867913002


Components: Internals>GPU
Ah, interesting. Finally got a repro on Mac, but to do that I had to ensure

chrome://flags/#ui-disable-partial-swap was "disabled".

That is, this does NOT reproduce if --ui-disable-partial-swap is on the command line. gpu-rasterization was a red-herring.

So

BROKEN: --disable-gpu
WORKS: --disable-gpu --ui-disable-partial-swap

And it looks like the software renderer just returns true for CanPartialSwap(), but the hardware renderer has some feature detection. So, --disable-gpu might not be a requirement for this to manifest.
Seems likely this was my change. Taking a look.
Mergedinto: 682074
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
duplicate in #9 was a mistake - re-opening.
tapted@ helped me track down my issue. I mistakingly got into a weird state while developing Material Design Settings so my hardware accelerator was turned off in chrome://settings/system. I flipped that back on and reset my flags and the issue seems resolved. 

Feel free to close this bug if there's no other concerns. Thanks everyone.
@11: It's still a bug if this only occurs with hardware acceleration disabled -- not all users will have hardware acceleration.
Re #12 - agreed - I've found the cause, will have a fix out today.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98c422c7b0b81c19765850453c761a074d242a03

commit 98c422c7b0b81c19765850453c761a074d242a03
Author: Eric Karl <ericrk@google.com>
Date: Tue Jun 06 23:08:38 2017

Restrict SW Renderer clear to scissor

The refactoring in crrev.com/2867913002 did not correctly handle cases
where we cleared with a scissor active. This change ensures that the
clear only applies to the scissored pixels.

Bug:  729363 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1be4e55b112ddf3291c1883fccf1084dc0c90f79
Reviewed-on: https://chromium-review.googlesource.com/526301
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477453}
[modify] https://crrev.com/98c422c7b0b81c19765850453c761a074d242a03/cc/output/software_renderer.cc

Labels: Merge-Request-60
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 8 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ac3185caec2f97ef777b48f6b54dd83d58157a4

commit 2ac3185caec2f97ef777b48f6b54dd83d58157a4
Author: Eric Karl <ericrk@chromium.org>
Date: Thu Jun 08 21:44:12 2017

Restrict SW Renderer clear to scissor

The refactoring in crrev.com/2867913002 did not correctly handle cases
where we cleared with a scissor active. This change ensures that the
clear only applies to the scissored pixels.

Bug:  729363 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I1be4e55b112ddf3291c1883fccf1084dc0c90f79
Reviewed-on: https://chromium-review.googlesource.com/526301
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477453}
Review-Url: https://codereview.chromium.org/2926403002 .
Cr-Commit-Position: refs/branch-heads/3112@{#269}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/2ac3185caec2f97ef777b48f6b54dd83d58157a4/cc/output/software_renderer.cc

Cc: ligim...@chromium.org csharrison@chromium.org ericrk@chromium.org
 Issue 726974  has been merged into this issue.
Status: Fixed (was: Assigned)
Cc: rbasuvula@chromium.org
Labels: Needs-Feedback
Tested in Reported version #61.0.3119.0 and Not able to reproduce the issue.
Steps Followed:
1.Disable the flag " --disable-gpu-rasterization" and disable " --disable-gpu" from command prompt.
2.click on book mark star icon and Hover over a button 
3.Dialog paint not disappearing for me.

@ericrk: Could you please let us know the exact steps to test this issue from TE end

Thanks in Advance.

Sign in to add a comment