Issue metadata
Sign in to add a comment
|
Dialog paint disappears when hovering over buttons |
||||||||||||||||||||||||
Issue descriptionVersion 61.0.3119.0 Mac What steps will reproduce the problem? (1) Open any chrome dialog, e.g. bookmarks or OIB (2) Hover over a button (3) Dialog paint will disappear, but button functionality and appearance will remain
,
Jun 5 2017
I haven't been able to reproduce this on Mac yet (tried up to 61.0.3119.0), but I managed to repro on Windows in a browser_tests build (at r476210 - 61.0.3118.0) - see attached. browser_tests.exe --dialog=BookmarkBubbleViewBrowserTest.InvokeDialog_bookmark_details --gtest_filter=BrowserDialogTest.Invoke --interactive --enable-pixel-output-in-tests --secondary-ui-md It seems that as soon as a Layer is made invisible, the root canvas is cleared. The Layer can be the one we now use for the text input cursor/ibeam, or an InkDrop layer on MD buttons (so with the former, --secondary-ui-md isn't needed to repro this).
,
Jun 5 2017
(inline video.. finally figured out how to do this on mac..)
,
Jun 5 2017
+CC bruthig who worked with layers when adding InkDrop stuff.
,
Jun 5 2017
OK I found the magic combo. With: --disable-gpu --disable-gpu-rasterization This reproduces for me reliably on Windows official build for 61.0.3119.0.
,
Jun 5 2017
You are probably looking for a change made after 470979 (known good), but no later than 470991 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/1852efa6e4d9c3353cd43d1815929d46e0f19a70..67fdcd138ad6a6a8c27848b668355f8c571a89a1 Suspect Avoid using SkClipOp::kReplace_deprecated in software renderer - r470981 -> https://codereview.chromium.org/2867913002
,
Jun 5 2017
Ah, interesting. Finally got a repro on Mac, but to do that I had to ensure chrome://flags/#ui-disable-partial-swap was "disabled". That is, this does NOT reproduce if --ui-disable-partial-swap is on the command line. gpu-rasterization was a red-herring. So BROKEN: --disable-gpu WORKS: --disable-gpu --ui-disable-partial-swap And it looks like the software renderer just returns true for CanPartialSwap(), but the hardware renderer has some feature detection. So, --disable-gpu might not be a requirement for this to manifest.
,
Jun 5 2017
Seems likely this was my change. Taking a look.
,
Jun 5 2017
,
Jun 5 2017
duplicate in #9 was a mistake - re-opening.
,
Jun 6 2017
tapted@ helped me track down my issue. I mistakingly got into a weird state while developing Material Design Settings so my hardware accelerator was turned off in chrome://settings/system. I flipped that back on and reset my flags and the issue seems resolved. Feel free to close this bug if there's no other concerns. Thanks everyone.
,
Jun 6 2017
@11: It's still a bug if this only occurs with hardware acceleration disabled -- not all users will have hardware acceleration.
,
Jun 6 2017
Re #12 - agreed - I've found the cause, will have a fix out today.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98c422c7b0b81c19765850453c761a074d242a03 commit 98c422c7b0b81c19765850453c761a074d242a03 Author: Eric Karl <ericrk@google.com> Date: Tue Jun 06 23:08:38 2017 Restrict SW Renderer clear to scissor The refactoring in crrev.com/2867913002 did not correctly handle cases where we cleared with a scissor active. This change ensures that the clear only applies to the scissored pixels. Bug: 729363 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1be4e55b112ddf3291c1883fccf1084dc0c90f79 Reviewed-on: https://chromium-review.googlesource.com/526301 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#477453} [modify] https://crrev.com/98c422c7b0b81c19765850453c761a074d242a03/cc/output/software_renderer.cc
,
Jun 8 2017
,
Jun 8 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ac3185caec2f97ef777b48f6b54dd83d58157a4 commit 2ac3185caec2f97ef777b48f6b54dd83d58157a4 Author: Eric Karl <ericrk@chromium.org> Date: Thu Jun 08 21:44:12 2017 Restrict SW Renderer clear to scissor The refactoring in crrev.com/2867913002 did not correctly handle cases where we cleared with a scissor active. This change ensures that the clear only applies to the scissored pixels. Bug: 729363 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1be4e55b112ddf3291c1883fccf1084dc0c90f79 Reviewed-on: https://chromium-review.googlesource.com/526301 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#477453} Review-Url: https://codereview.chromium.org/2926403002 . Cr-Commit-Position: refs/branch-heads/3112@{#269} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/2ac3185caec2f97ef777b48f6b54dd83d58157a4/cc/output/software_renderer.cc
,
Jun 9 2017
Issue 726974 has been merged into this issue.
,
Jun 12 2017
,
Jun 14 2017
Tested in Reported version #61.0.3119.0 and Not able to reproduce the issue. Steps Followed: 1.Disable the flag " --disable-gpu-rasterization" and disable " --disable-gpu" from command prompt. 2.click on book mark star icon and Hover over a button 3.Dialog paint not disappearing for me. @ericrk: Could you please let us know the exact steps to test this issue from TE end Thanks in Advance. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bettes@chromium.org
, Jun 3 2017