New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 729336 link

Starred by 1 user
Status: Started
Owner:
█ borenet@chromium.org
Last visit > 30 days ago
Cc:
d...@chromium.org
no...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

recipe_modules/chromium_tests/client_skia.py modifies recipe engine's sys.path in build.git

Project Member Reported by iannucci@chromium.org, Jun 3 2017 
Currently the chromium_tests/client_skia.py file globally modifies the recipe_engine's sys.path. We need to come up with a better solution for this:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/client_skia.py?q=client_skia+package:%5Echromium$&l=1

There's a lot of indirection going on here, it's hard for me to tell what this is actually doing.

Comment 1 by bore...@google.com, Jun 5 2017 

This was a hacky way of copying a few of Chromium's bot configs in order to run them as Skia bots (to predict DEPS roll failures before they failed on CQ).  It can be safely deleted (and apologies for not having done it earlier).

https://chromium-review.googlesource.com/c/524102/

Comment 4 by iannucci@chromium.org, Jun 5 2017 

woohoo! best solution to this bug :DDD

I'll help out on the public one which looks like it's hitting some presubmit issues.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/6116cb38558e26fccba56bd9b76eac753bb75570

commit 6116cb38558e26fccba56bd9b76eac753bb75570
Author: Eric Boren <borenet@google.com>
Date: Tue Jun 06 12:33:44 2017
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d7481d4553c44d64083c5eba1013475b2d6f27bd

commit d7481d4553c44d64083c5eba1013475b2d6f27bd
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Jun 07 18:19:07 2017

Remove a bunch of old Skia stuff

TBR=dpranke@chromium.org

Bug: 729336
Change-Id: I41b8c8909f16ca6a28ca46368d924786c0683f54
Reviewed-on: https://chromium-review.googlesource.com/526270
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Eric Boren <borenet@chromium.org>

[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/builders.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/OWNERS
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/Makefile
[modify] https://crrev.com/d7481d4553c44d64083c5eba1013475b2d6f27bd/scripts/slave/unittests/recipe_lint_test.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/builders.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/slaves.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/master_site_config.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/builders.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/master_site_config.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/master/skia/OWNERS
[modify] https://crrev.com/d7481d4553c44d64083c5eba1013475b2d6f27bd/scripts/slave/recipe_modules/chromium_tests/builders.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/builders.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/Makefile
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/common/skia/builder_name_schema.json
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/master/skia/skia_notifier.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/common/skia/OWNERS
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/slave/recipe_modules/chromium_tests/client_skia.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/master_site_config.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/OWNERS
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/slaves.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/master/skia/status_json.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/public_html/default.css
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/slaves.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/master.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/OWNERS
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/master.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/public_html/favicon.ico
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/OWNERS
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/common/skia/__init__.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/templates/console.html
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/master.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/common/skia/builder_name_schema.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/master/skia/skia_master_utils.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/Makefile
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/common/skia/global_constants.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.compile/master_site_config.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.android/master.cfg
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/templates/tree_status.html
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/public_html/common-resources
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia.fyi/Makefile
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/scripts/master/skia/__init__.py
[modify] https://crrev.com/d7481d4553c44d64083c5eba1013475b2d6f27bd/tests/masters_test.py
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/slaves.cfg
[modify] https://crrev.com/d7481d4553c44d64083c5eba1013475b2d6f27bd/scripts/slave/logdog-params.pyl
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/templates/announce.html
[delete] https://crrev.com/13c87602d802d581d874cc38e9d5761bce6dc87e/masters/master.client.skia/templates/horizontal_one_box_per_build.html

Comment 7 by bore...@google.com, Jun 7 2017

Status: Fixed (was: Untriaged)
Fixed by deleting the code.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/429591827f1fe6ad84ed72a8dc1746520f7d3adf

commit 429591827f1fe6ad84ed72a8dc1746520f7d3adf
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Jun 07 19:34:21 2017

Revert "Remove a bunch of old Skia stuff"

This reverts commit d7481d4553c44d64083c5eba1013475b2d6f27bd.

Reason for revert: Breaks several internal builders in official.desktop.continuous waterfall, among others.
Seems there's some problem in the rolling mechanism that only hits internal builders here.

Original change's description:
> Remove a bunch of old Skia stuff
> 
> TBR=dpranke@chromium.org
> 
> Bug: 729336
> Change-Id: I41b8c8909f16ca6a28ca46368d924786c0683f54
> Reviewed-on: https://chromium-review.googlesource.com/526270
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Eric Boren <borenet@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,borenet@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 729336

Change-Id: Ifc9f7fbd04e6024b77ea4709df6747a494f8e69a
Reviewed-on: https://chromium-review.googlesource.com/527433
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/Makefile
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/unittests/recipe_lint_test.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/OWNERS
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/recipe_modules/chromium_tests/builders.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/builder_name_schema.json
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/skia_notifier.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/recipe_modules/chromium_tests/client_skia.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/status_json.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/default.css
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/favicon.ico
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/__init__.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/console.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/builder_name_schema.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/skia_master_utils.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/global_constants.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/tree_status.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/common-resources
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/__init__.py
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/tests/masters_test.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/slaves.cfg
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/logdog-params.pyl
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/announce.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/horizontal_one_box_per_build.html
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/429591827f1fe6ad84ed72a8dc1746520f7d3adf

commit 429591827f1fe6ad84ed72a8dc1746520f7d3adf
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Jun 07 19:34:21 2017

Revert "Remove a bunch of old Skia stuff"

This reverts commit d7481d4553c44d64083c5eba1013475b2d6f27bd.

Reason for revert: Breaks several internal builders in official.desktop.continuous waterfall, among others.
Seems there's some problem in the rolling mechanism that only hits internal builders here.

Original change's description:
> Remove a bunch of old Skia stuff
> 
> TBR=dpranke@chromium.org
> 
> Bug: 729336
> Change-Id: I41b8c8909f16ca6a28ca46368d924786c0683f54
> Reviewed-on: https://chromium-review.googlesource.com/526270
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Eric Boren <borenet@chromium.org>

TBR=iannucci@chromium.org,dpranke@chromium.org,borenet@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 729336

Change-Id: Ifc9f7fbd04e6024b77ea4709df6747a494f8e69a
Reviewed-on: https://chromium-review.googlesource.com/527433
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/Makefile
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/unittests/recipe_lint_test.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/OWNERS
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/recipe_modules/chromium_tests/builders.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/builders.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/builder_name_schema.json
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/skia_notifier.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/recipe_modules/chromium_tests/client_skia.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/status_json.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/default.css
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/slaves.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/favicon.ico
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/OWNERS
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/__init__.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/console.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/builder_name_schema.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/skia_master_utils.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/common/skia/global_constants.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.compile/master_site_config.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.android/master.cfg
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/tree_status.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/public_html/common-resources
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia.fyi/Makefile
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/master/skia/__init__.py
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/tests/masters_test.py
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/slaves.cfg
[modify] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/scripts/slave/logdog-params.pyl
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/announce.html
[add] https://crrev.com/429591827f1fe6ad84ed72a8dc1746520f7d3adf/masters/master.client.skia/templates/horizontal_one_box_per_build.html
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bf44e26eaacd2909bcc2a12d7764711ccf08f09e

commit bf44e26eaacd2909bcc2a12d7764711ccf08f09e
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Jun 08 00:05:33 2017

Remove skia from build recipes.

This should be safer to land than the original[1] because it will remove
the recipes' dependency on the unpinned /b/build repo.

[1]: https://chromium-review.googlesource.com/c/527433

R=borenet@chromium.org, dnj@chromium.org

Bug: 729336
Change-Id: I4bcc1101a912a84c5e35121bd1689f37086aa8b8
Reviewed-on: https://chromium-review.googlesource.com/527897
Reviewed-by: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/bf44e26eaacd2909bcc2a12d7764711ccf08f09e/scripts/slave/recipe_modules/chromium_tests/builders.py
[modify] https://crrev.com/bf44e26eaacd2909bcc2a12d7764711ccf08f09e/scripts/slave/unittests/recipe_lint_test.py
[delete] https://crrev.com/72de79c98b0c3dd7bbce10bd489c8b5aaad46618/scripts/slave/recipe_modules/chromium_tests/client_skia.py

Comment 11 by bore...@google.com, Jun 8 2017

Status: Started (was: Fixed)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4

commit aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Jun 10 02:45:59 2017

[partial reland] Remove a bunch of old Skia stuff

This partially relands https://chromium-review.googlesource.com/c/526270/,
but without the recipe bits, which landed in
https://chromium-review.googlesource.com/c/527897/.

R=borenet@chromium.org, dimu@chromium.org, dnj@chromium.org

Bug:  662654 , 729336
Change-Id: If99c3639f1c126721bb30e6cb48b02a7c8afae7c
Reviewed-on: https://chromium-review.googlesource.com/530285
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Di Mu <dimu@chromium.org>

[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/OWNERS
[modify] https://crrev.com/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4/tests/masters_test.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/builders.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/builder_name_schema.json
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/skia_notifier.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/status_json.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/default.css
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/slaves.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/favicon.ico
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/OWNERS
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/__init__.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/console.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/builder_name_schema.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/skia_master_utils.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/common/skia/global_constants.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.compile/master_site_config.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.android/master.cfg
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/tree_status.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/public_html/common-resources
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia.fyi/Makefile
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/scripts/master/skia/__init__.py
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/slaves.cfg
[modify] https://crrev.com/aff74dbecfc70344a72c5fee7fc85eabcb7cb9a4/scripts/slave/logdog-params.pyl
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/announce.html
[delete] https://crrev.com/ea2364b365eff485747dd7a7ee25a08d1e18b03b/masters/master.client.skia/templates/horizontal_one_box_per_build.html

Comment 13 by benhenry@chromium.org, Aug 2

Owner: borenet@chromium.org
►

Sign in to add a comment