New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729331 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

"WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 3 2017

Issue description

"WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 15 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBXaWRnZXRUZXN0SW50ZXJhY3RpdmUuRGVza3RvcE5hdGl2ZVdpZGdldFdpdGhNb2RhbFRyYW5zaWVudENoaWxkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 5 2017

Detected 4 new flakes for test/step "WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkBXaWRnZXRUZXN0SW50ZXJhY3RpdmUuRGVza3RvcE5hdGl2ZVdpZGdldFdpdGhNb2RhbFRyYW5zaWVudENoaWxkDA. This message was posted automatically by the chromium-try-flakes app.
Cc: warx@chromium.org
Owner: blundell@chromium.org
Status: Started (was: Untriaged)
This test was added in https://codereview.chromium.org/2919973002/ and has been flaky since. Reverting that CL in https://codereview.chromium.org/2921253002/.
Labels: -Sheriff-Chromium
Status: Fixed (was: Started)
The revert landed.

Comment 4 by warx@chromium.org, Jun 6 2017

Cc: -warx@chromium.org blundell@chromium.org
Labels: -Pri-1 OS-Windows Pri-3
Owner: warx@chromium.org
Status: Assigned (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f90ea81c1e46f8e20f84e0449f397d19f809c8

commit 81f90ea81c1e46f8e20f84e0449f397d19f809c8
Author: warx <warx@chromium.org>
Date: Wed Jun 07 20:47:12 2017

Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN

Changes:
This is a speculative fix of flakiness of
WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild.
WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix.

R=sky@chromium.org
BUG= 729331 
TEST=trybot tests

Review-Url: https://codereview.chromium.org/2926683003
Cr-Commit-Position: refs/heads/master@{#477754}

[modify] https://crrev.com/81f90ea81c1e46f8e20f84e0449f397d19f809c8/ui/views/widget/widget_interactive_uitest.cc

Comment 6 by warx@chromium.org, Jun 7 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81f90ea81c1e46f8e20f84e0449f397d19f809c8

commit 81f90ea81c1e46f8e20f84e0449f397d19f809c8
Author: warx <warx@chromium.org>
Date: Wed Jun 07 20:47:12 2017

Enable WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild on OS_WIN

Changes:
This is a speculative fix of flakiness of
WidgetTestInteractive.DesktopNativeWidgetWithModalTransientChild.
WidgetInputMethodInteractiveTest::SetUp() instructs the possible fix.

R=sky@chromium.org
BUG= 729331 
TEST=trybot tests

Review-Url: https://codereview.chromium.org/2926683003
Cr-Commit-Position: refs/heads/master@{#477754}

[modify] https://crrev.com/81f90ea81c1e46f8e20f84e0449f397d19f809c8/ui/views/widget/widget_interactive_uitest.cc

Sign in to add a comment