suite_scheduler.ini typos should not cause suite scheduler to crash |
||||||
Issue description06/03 10:10:51.001 INFO | suite_scheduler:0263| Connecting to: chromeos-server30.cbf.corp.google.com 06/03 10:10:51.002 DEBUG| utils:0203| Running 'which git' 06/03 10:10:54.185 DEBUG| autotemp:0116| Clean was not called for /tmp/_autotmp_a7f6DS_suite_scheduler ... and then the log ends
,
Jun 3 2017
The "which git" logging is coming from the initializion pathway from suite_scheduler.py, from the constructor to ManifestVersions. That constructor also sets up the tmp directory that is failing to be cleaned.
logging.info('Connecting to: %s' , afe.server)
enumerator = board_enumerator.BoardEnumerator(afe)
scheduler = deduping_scheduler.DedupingScheduler(afe, options.file_bug)
mv = manifest_versions.ManifestVersions(options.tmp_repo_dir)
,
Jun 3 2017
,
Jun 3 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/731769a4b77a47a7405c6d5e7faf203449143f53 commit 731769a4b77a47a7405c6d5e7faf203449143f53 Author: Aviv Keshet <akeshet@chromium.org> Date: Sat Jun 03 17:25:03 2017
,
Jun 3 2017
Crashlooping was fixed by ^ plus forced puppet run. Follow ups: 1) If suite_scheduler.ini is not parseable, that should be made obvious from the suite_scheduler logs. 2a) Puppet should ensure parsesability before dropping a new suite_scheduler.ini 2b) Or, suite_scheduler should switch to a forgiving parser, so that only the suite definitions that are malformed are affected, not the entire set.
,
Jun 5 2017
,
Jun 5 2017
Notes: there's a test, it doesn't run automatically (Dan / Xixuan have details about the test).
,
Jun 5 2017
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8cd835fc81e1a97332918fc4c277faf5e6e44093 commit 8cd835fc81e1a97332918fc4c277faf5e6e44093 Author: Dan Shi <dshi@google.com> Date: Tue Jun 13 03:27:56 2017 [autotest] Handle config error in suite scheduler. This change adds more error handling in parsing a task. If a task has bad config values, log the error and ignore the task. BUG= chromium:729330 TEST=unittest Change-Id: Idfc068781211f4535dec5f2debbee671dc13ccc0 Reviewed-on: https://chromium-review.googlesource.com/531755 Commit-Ready: Dan Shi <dshi@google.com> Tested-by: Dan Shi <dshi@google.com> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/8cd835fc81e1a97332918fc4c277faf5e6e44093/site_utils/suite_scheduler/task_unittest.py [modify] https://crrev.com/8cd835fc81e1a97332918fc4c277faf5e6e44093/site_utils/suite_scheduler/task.py [modify] https://crrev.com/8cd835fc81e1a97332918fc4c277faf5e6e44093/site_utils/suite_scheduler/forgiving_config_parser.py [modify] https://crrev.com/8cd835fc81e1a97332918fc4c277faf5e6e44093/site_utils/suite_scheduler/driver.py [add] https://crrev.com/8cd835fc81e1a97332918fc4c277faf5e6e44093/site_utils/suite_scheduler/error.py
,
Jun 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by akes...@chromium.org
, Jun 3 2017