New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729298 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in blink::StringResourceBase::~StringResourceBase

Project Member Reported by ClusterFuzz, Jun 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5436765380018176

Fuzzer: inferno_canvas_wrecker
Job Type: linux_msan_chrome
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  blink::StringResourceBase::~StringResourceBase
  blink::StringResource8::~StringResource8
  v8::internal::ExternalStringTableCleaner::VisitRootPointers
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_chrome&range=476635:476657

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5436765380018176


Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 3 2017

Labels: M-60
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 3 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 3 2017

Labels: Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -M-60 M-61
Owner: hpayer@chromium.org
Status: Assigned (was: Untriaged)
this is https://chromium.googlesource.com/v8/v8/+/502c6ae6a03979efbd3e006e6a0b8c3369ca2bbc
Components: Blink>JavaScript>GC Blink>MemoryAllocator>GarbageCollection
Cc: hpayer@chromium.org
 Issue 730576  has been merged into this issue.

Comment 9 by hpayer@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)
Fixed by:
commit 11fc9fab94d48b389cb239d1fa06413682a12eb6
Author: ulan <ulan@chromium.org>
Date:   Tue Jun 6 10:31:24 2017 -0700

    [heap] Guard against re-entering GC on external memory change.
    
    TBR=hpayer@chromium.org
    BUG=chromium:729868, chromium:729521 
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
    
    Review-Url: https://codereview.chromium.org/2929463002
    Cr-Commit-Position: refs/heads/master@{#45745}

Project Member

Comment 10 by sheriffbot@chromium.org, Jun 12 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: M-60 Merge-Request-60
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 21 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
This is missing a regression test, but otherwise looks good for merging.  Is there anyone that can add one, similar to https://chromium-review.googlesource.com/c/532900/
Cc: awhalley@chromium.org
+awhalley@ 
Labels: -Hotlist-Merge-Review -ReleaseBlock-Stable -M-60 -Merge-Review-60
Actually... looks like the regression was in M61, so no need for M60 merge.
Project Member

Comment 17 by sheriffbot@chromium.org, Sep 18 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment