New issue
Advanced search Search tips

Issue 729295 link

Starred by 1 user
Status: Fixed
Owner:
blundell@chromium.org
Closed: Jun 2017
Cc:
pmonette@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 3 2017 
"SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJTcGVsbGNoZWNrQ3VzdG9tRGljdGlvbmFyeVRlc3QuU3luY0JlZm9yZUxvYWREb2VzTm90RHVwbGljYXRlV29yZHMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jun 5 2017 

Detected 3 new flakes for test/step "SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTQsSBUZsYWtlIkJTcGVsbGNoZWNrQ3VzdG9tRGljdGlvbmFyeVRlc3QuU3luY0JlZm9yZUxvYWREb2VzTm90RHVwbGljYXRlV29yZHMM. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by blundell@chromium.org, Jun 5 2017

Owner: blundell@chromium.org
Status: Started (was: Untriaged)

Comment 3 by blundell@chromium.org, Jun 5 2017

Cc: pmonette@chromium.org
Reverting speculative offender in https://chromium-review.googlesource.com/c/523723.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac928962d23329e6314b5c3693a37d160048f4d5

commit ac928962d23329e6314b5c3693a37d160048f4d5
Author: Colin Blundell <blundell@chromium.org>
Date: Mon Jun 05 15:29:36 2017

Revert "Remove the usage of BrowserThread::FILE in the spellchecker files"

This reverts commit 34d81247acae78f200dd487b952e7f77687b5616.

Reason for revert: The spellcheck custom dictionary unittest became flaky shortly after this CL landed (CL landed at #476784, flake started on a tryjob run against #476796).

Here's an example failure:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_x64_rel_ng%2F442195%2F%2B%2Frecipes%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FSpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords%2F0

Will reland this CL if flake continues after the revert.

Bug:  729295 

Original change's description:
> Remove the usage of BrowserThread::FILE in the spellchecker files
> 
> The usage of BrowserThread::FILE is deprecated in favor of the
> post_task.h API.
> 
> BUG= 689520 
> 
> Change-Id: I49e25a3ab58129807c6361b4087f35d30fc37951
> Reviewed-on: https://chromium-review.googlesource.com/510018
> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
> Commit-Queue: Patrick Monette <pmonette@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476784}

TBR=rouslan@chromium.org,pmonette@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG= 689520 

Change-Id: I9c160f48ee0883c701a9d980b5af2720b19a8d66
Reviewed-on: https://chromium-review.googlesource.com/523723
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476988}
[modify] https://crrev.com/ac928962d23329e6314b5c3693a37d160048f4d5/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc
[modify] https://crrev.com/ac928962d23329e6314b5c3693a37d160048f4d5/chrome/browser/spellchecker/spellcheck_custom_dictionary.h
[modify] https://crrev.com/ac928962d23329e6314b5c3693a37d160048f4d5/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc
[modify] https://crrev.com/ac928962d23329e6314b5c3693a37d160048f4d5/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.h
[modify] https://crrev.com/ac928962d23329e6314b5c3693a37d160048f4d5/chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Comment 5 by dpranke@chromium.org, Jun 5 2017 

So far this looks pretty good (I haven't seen any additional failures).

Comment 6 by dpranke@chromium.org, Jun 6 2017

Status: Fixed (was: Started)
I haven't seen this fail all day after the revert. I'm taking it out of the sheriff queue and marking this as closed.

Comment 7 by noel@chromium.org, Sep 19 2017 

Still flakes sometimes.

https://luci-milo.appspot.com/buildbot/tryserver.chromium.win/win_chromium_rel_ng/535267

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_chromium_rel_ng%2F535267%2F%2B%2Frecipes%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FSpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords%2F0

[ RUN      ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords
../../chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc(523): error:       Expected: kExpectedContentsPrefix
      Which is: "foo\nchecksum_v1 = "
To be equal to: actual_contents_on_disk.substr(0, sizeof kExpectedContentsPrefix - 1)
      Which is: ""
With diff:
@@ -1,2 +1,1 @@
-foo
-checksum_v1 =
+""
[  FAILED  ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords (43 ms)
[ RUN      ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords
../../chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc(523): error:       Expected: kExpectedContentsPrefix
      Which is: "foo\nchecksum_v1 = "
To be equal to: actual_contents_on_disk.substr(0, sizeof kExpectedContentsPrefix - 1)
      Which is: ""
With diff:
@@ -1,2 +1,1 @@
-foo
-checksum_v1 =
+""
[  FAILED  ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords (43 ms)
[ RUN      ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords
../../chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc(523): error:       Expected: kExpectedContentsPrefix
      Which is: "foo\nchecksum_v1 = "
To be equal to: actual_contents_on_disk.substr(0, sizeof kExpectedContentsPrefix - 1)
      Which is: ""
With diff:
@@ -1,2 +1,1 @@
-foo
-checksum_v1 =
+""
[  FAILED  ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords (32 ms)
[ RUN      ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords
../../chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc(523): error:       Expected: kExpectedContentsPrefix
      Which is: "foo\nchecksum_v1 = "
To be equal to: actual_contents_on_disk.substr(0, sizeof kExpectedContentsPrefix - 1)
      Which is: ""
With diff:
@@ -1,2 +1,1 @@
-foo
-checksum_v1 =
+""
[  FAILED  ] SpellcheckCustomDictionaryTest.SyncBeforeLoadDoesNotDuplicateWords (33 ms)
►

Sign in to add a comment