New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729289 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Mojo JS bindings are not fully functional in WebUI

Project Member Reported by roc...@chromium.org, Jun 3 2017

Issue description

The global object attributes are there (e.g. Mojo, MojoHandle, etc), but their own attributes, methods, etc, are missing.

This is due to a simple conflict between RuntimeEnabled and ContextEnabled implementation.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec7d0dbc167c92009f27646d53ccfc93299a4139

commit ec7d0dbc167c92009f27646d53ccfc93299a4139
Author: Ken Rockot <rockot@chromium.org>
Date: Mon Jun 05 13:54:59 2017

Fix conflict between RuntimeEnabled and ContextEnabled features

An optimization (added in r443179) causes certain feature installation
code to exit early if an associated RuntimeEnabled flag isn't set.
However this code is now also used to install optional (e.g.
ContextEnabled) features. This conflict can cause certain API features
to be omitted from object templates even when an optional feature is
explicitly enabled for a given context.

This CL omits the optimization for RuntimeEnabled features which also
support ContextEnabled. The omission of this condition does not cause
a RuntimeEnabled feature to be exposed unintentionally in any case; it
only causes some extra (redundant) RuntimeEnabled checks when an API
feature also supports ContextEnabled.

BUG= 729289 

Change-Id: I1c813043019e5a989dd81ed27ee4fd4892c6d606
Reviewed-on: https://chromium-review.googlesource.com/523272
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476978}
[modify] https://crrev.com/ec7d0dbc167c92009f27646d53ccfc93299a4139/content/test/data/web_ui_mojo_native.js
[modify] https://crrev.com/ec7d0dbc167c92009f27646d53ccfc93299a4139/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/ec7d0dbc167c92009f27646d53ccfc93299a4139/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/ec7d0dbc167c92009f27646d53ccfc93299a4139/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment