scroll anchoring uses wrong edge in vertical-lr with rtl |
||
Issue descriptionRepro: https://output.jsbin.com/lujaqij/quiet (and attached) Click the green box. Expected: green box grows to the right Actual: green box grows to the left ScrollAnchor is getting its corners confused. In vertical-lr the blocks are laid out from left to right, so we should anchor to the (physical) left edge of the anchor node.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c316847a808e70590eb0af0486efbd9a92152e commit d1c316847a808e70590eb0af0486efbd9a92152e Author: Steve Kobes <skobes@chromium.org> Date: Tue Jun 06 04:39:29 2017 In vertical-lr mode, anchor to left edge regardless of RTL. RTL reverses the inline flow direction, but this is irrelevant to ScrollAnchor after r420329. Only the block flow direction matters in determining which edge of the anchor node to base our adjustment on. Bug: 729279 Change-Id: Iea9b7f982a9a162594388fa3b330272b1b05e016 Reviewed-on: https://chromium-review.googlesource.com/523275 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#477196} [modify] https://crrev.com/d1c316847a808e70590eb0af0486efbd9a92152e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d1c316847a808e70590eb0af0486efbd9a92152e/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
,
Jun 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by skobes@chromium.org
, Jun 5 2017Status: Started (was: Available)