New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729262 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: received_packet->ssrc == recovered_packet->ssrc in forward_error_correction.cc

Project Member Reported by ClusterFuzz, Jun 3 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5417141942878208

Fuzzer: libFuzzer_flexfec_receiver_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  received_packet->ssrc == recovered_packet->ssrc in forward_error_correction.cc
  rtc::FatalMessage::~FatalMessage
  webrtc::ForwardErrorCorrection::InsertMediaPacket
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=476634:476682

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5417141942878208


Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: msrchandra@chromium.org
Components: Blink>WebRTC
Labels: M-60 Test-Predator-Correct-CLs
Owner: brandtr@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: brandtr
Project: chromium-webrtc
Changelist: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/26d4b319ba13614e6e25172771ede6965f8e7663
Time: Fri Jun 02 07:58:11 2017
Lines 345, 727-730 of file forward_error_correction.cc which potentially caused crash are changed in this cl (frame #8, "webrtc::ForwardErrorCorrection::InsertMediaPacket"; frame #10, "webrtc::ForwardErrorCorrection::DecodeFec").
Minimum distance from crash line to modified line: 0. (file: forward_error_correction.cc, crashed on: 727, modified: 727).

@brandtr -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by ClusterFuzz, Jun 9 2017

ClusterFuzz has detected this issue as fixed in range 477952:477980.

Detailed report: https://clusterfuzz.com/testcase?key=5417141942878208

Fuzzer: libFuzzer_flexfec_receiver_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  received_packet->ssrc == recovered_packet->ssrc in forward_error_correction.cc
  rtc::FatalMessage::~FatalMessage
  webrtc::ForwardErrorCorrection::InsertMediaPacket
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=476634:476682
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=477952:477980

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5417141942878208


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Status: Fixed (was: Assigned)

Comment 4 by jansson@webrtc.org, Jun 12 2017

brandtr@ could you add the CL that fixed it in this bug? Also, did you add a test to cover for this?
Cc: jansson@chromium.org
This was fixed by reverting the change that introduced the problem. https://codereview.webrtc.org/2919313005/

The CL has not been relanded yet; trying to figure out how to deal with the problem is a nice way.

Sign in to add a comment