shill: ChromeosSupplicantInterfaceProxy::SetHT40Enable is no-op on ChromeOS |
||||
Issue descriptionIt seems like https://android-review.googlesource.com/#/c/174019 put an incorrect guard on ChromeosSupplicantInterfaceProxy::SetHT40Enable, which made it a no-op on ChromeOS (rather than a no-op on Android).
,
Jun 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/25a275863142af602b182e1c2f3fe78ae441cef3 commit 25a275863142af602b182e1c2f3fe78ae441cef3 Author: Ben Chan <benchan@chromium.org> Date: Sat Jun 03 19:39:24 2017 shill: fix ChromeosSupplicantInterfaceProxy::SetHT40Enable https://android-review.googlesource.com/#/c/174019/ added several `#if !defined(__ANDROID__)` guards in ChromeosSupplicantInterfaceProxy to skip unsupported D-Bus calls to wpa_supplicant on Android. However, the guard in ChromeosSupplicantInterfaceProxy::SetHT40Enable is incorrect, which causes SetHT40Enable to be ignored on Chrome OS. BUG= chromium:729259 TEST=Run unit tests. Change-Id: Ie8de92c66ff9f76d3de317a5abb0e7e92f13ce06 Reviewed-on: https://chromium-review.googlesource.com/522935 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/25a275863142af602b182e1c2f3fe78ae441cef3/dbus/chromeos_supplicant_interface_proxy.cc
,
Jun 4 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by benchan@chromium.org
, Jun 3 2017