Issue metadata
Sign in to add a comment
|
gpu execution trace missing |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 60.0.3112.10 (Official Build) dev (64-bit) Open about:tracing, manually select "gpu" category, capture a trace. In the gpu process, there should be a trace with the identity of the context. Prior to be0c1281af4417e8b27b967cc067ad388e577bf8/https://chromium-review.googlesource.com/516422 one would see the "CommandExecutor:PutChanged" trace with the identity of the running context as the "handler" parameter. This is very important to debug performance issues. Unfortunately that CL lost the trace and we lost that key piece of info.
,
Jun 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd5ac9164eebef1d4d853f13fc8a51a322afe739 commit fd5ac9164eebef1d4d853f13fc8a51a322afe739 Author: Antoine Labour <piman@chromium.org> Date: Sat Jun 03 01:55:23 2017 Restore missing trace This was lost by https://chromium-review.googlesource.com/516422 but is important to debug performance issues. Bug: 729252 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I16aad8697473a2071b662c3d02fbf0f10e2de8b5 Reviewed-on: https://chromium-review.googlesource.com/523040 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#476853} [modify] https://crrev.com/fd5ac9164eebef1d4d853f13fc8a51a322afe739/gpu/command_buffer/service/command_buffer_service.cc
,
Jun 5 2017
Requesting merge. While the issue doesn't directly end users, it can impair our ability to debug performance problems on the branch and, once if it reaches stable, in the wild. The fix is trivial.
,
Jun 5 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97a8e47bf37726652dddb7a258295a2975189dc9 commit 97a8e47bf37726652dddb7a258295a2975189dc9 Author: Antoine Labour <piman@chromium.org> Date: Mon Jun 05 16:58:18 2017 Restore missing trace This was lost by https://chromium-review.googlesource.com/516422 but is important to debug performance issues. TBR=piman@chromium.org (cherry picked from commit fd5ac9164eebef1d4d853f13fc8a51a322afe739) Bug: 729252 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I16aad8697473a2071b662c3d02fbf0f10e2de8b5 Reviewed-on: https://chromium-review.googlesource.com/523040 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#476853} Reviewed-on: https://chromium-review.googlesource.com/524434 Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/branch-heads/3112@{#153} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/97a8e47bf37726652dddb7a258295a2975189dc9/gpu/command_buffer/service/command_buffer_service.cc
,
Jun 5 2017
,
Jun 6 2017
piman@: Can this be verified manually? If so, could you please help in providing steps for verification as I am not seeing any difference b/w before(60.0.3112.10) and after the fix(60.0.3112.20). Attached is the screenshot from chrome version: 60.0.3112.20, which contains the fix.
,
Jun 6 2017
If you zoom in on the CrGpuMain trace (using the tools or the "w"/"s" keys), the names for the individual events should show up as they get big enough. If the patch is functioning correctly, you should see a "CommandBufferService:PutChanged" event. If you click on it, you should see the properties show up in the bottom panel, among others under the "Args" category you should see a value for "handler" that consists in a name and a hex value - e.g. ".RenderWorker-0x3f5d74860020" |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by piman@chromium.org
, Jun 3 2017