New issue
Advanced search Search tips

Issue 729251 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----


Previous locations:
gerrit:6403


Sign in to add a comment

Red 'x' is confusing on try results

Project Member Reported by sky@chromium.org, Jun 2 2017

Issue description

If a try job fails the rectangle turns read and shows an 'X'. Generally in UI an 'X' means close. That isn't the case here as clicking the rectangle takes me to the result.
 

Comment 1 by wyatta@google.com, Jun 2 2017

Cc: aga...@chromium.org
Project: chromium
Moved issue gerrit:6403 to now be  issue chromium:729251 .
Components: Infra>Codereview>Gerrit
Labels: Milestone-Afterglow Proj-Gerrit-Migration Pri-3
Status: Available (was: New)
Please propose an icon (preferably from https://thenounproject.com/monstercritic/collection/tinicons-a-set-of-tiny-icons-perfect-for-ui-elemen/ for consistency) which you think would better portray the meaning and I will be happy to change it.

Comment 4 by sky@chromium.org, Jun 5 2017

Why do you need an icon at all? Doesn't the color convey the problem?
No, the icon is necessary for accessibility purposes. Some people have a
hard time distinguishing the various colors.

Comment 6 by sky@chromium.org, Jun 5 2017

We didn't have icons with Rieveltd.

Why not group them differently, e.g.

Failed: [linux_chromium_chromeos_ozone]
Succeeded: [mac-chromium-rel]
In progress [...]
Yes, there weren't icons on Rietveld because when people complained about lack of accessibility, they were told that Rietveld was in maintenance mode and changes weren't being made. We're doing better than that now.

We do plan to group them differently, eventually. We do not plan to ditch the icons, unless people specifically focused on accessibility tell us they are not necessary anymore.

Comment 8 by sky@chromium.org, Jun 5 2017

There are ways to make the builder results more accessible that don't involve icons. Who said you need icons?
The bug tracking that work was here: https://bugs.chromium.org/p/chromium/issues/detail?id=704145. 

As I already said, we do plan to change the ordering. And yes, there are ways to do this that don't involve icons. However, changing this, especially at the behest of non-accessibility folks, is not a priority.

This issue has been triaged and will be revisited when we reach the next milestone.

Comment 10 by sky@chromium.org, Jun 5 2017

Understood. It's interesting to note that the first comment in https://bugs.chromium.org/p/chromium/issues/detail?id=704145 doesn't mention an icon.
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Status: WontFix (was: Available)
We haven't had any ideas for what to replace this with. The best I've come up with is https://www.gstatic.com/images/icons/material/system/1x/change_history_black_18dp.png, which isn't great. 

Sign in to add a comment