Search should be disabled when you have no Downloads, Bookmarks or History |
|||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 61.0.3115.0 Android Build Number (from "Android Settings > About Phone/Tablet"): 5.0.2 Device: Samsung SM-S920L What steps will reproduce the problem? (1)Open Canary without signing in (2)Navigate to Downloads, Bookmarks, or History (make sure these are empty) (3)Tap the search icon What is the expected result? If you have no Downloads, Bookmarks or History the search icon should be disabled What happens instead? You will enter a search state which will always have no results
,
Jun 19 2017
Search should be hidden. I know we have an issue on downloads where the info toggle and search icon re-appear after switching tabs, but I was previously unaware the other surfaces were experiencing issues as well.
,
Jun 20 2017
,
Jun 20 2017
,
Jul 27 2017
,
Aug 7 2017
Issue 753110 has been merged into this issue.
,
Aug 8 2017
Removing ownership since this is "available"
,
Aug 10 2017
,
Aug 22 2017
,
Aug 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df1ce35600347d2aabcfef01a0626e3c68f2e937 commit df1ce35600347d2aabcfef01a0626e3c68f2e937 Author: danielpark@chromium.org <danielpark@chromium.org> Date: Tue Aug 29 00:06:44 2017 [Home] Properly set search icon visibility when switching content > Adds new boolean mSelectableListHasItems in SelectableListToolbar. > Sets visibility for search icon using mSelectableListHasItems in showNormalView. Bug: 729244 Change-Id: I7e1f5511d14a346b8dbbfca433d42c62112d911e Reviewed-on: https://chromium-review.googlesource.com/627033 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Daniel Park <danielpark@chromium.org> Cr-Commit-Position: refs/heads/master@{#497949} [modify] https://crrev.com/df1ce35600347d2aabcfef01a0626e3c68f2e937/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
,
Sep 6 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by k...@chromium.org
, Jun 16 2017Labels: -Restrict-View-Google -Hotlist-Home-needs-triage Hotlist-Chrome-Home
Owner: twelling...@chromium.org