New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729224 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15%-19.8% regression in thread_times.key_silk_cases at 476202:476314

Project Member Reported by m...@chromium.org, Jun 2 2017

Issue description

See the link to graphs below.
 

Comment 1 by m...@chromium.org, Jun 2 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=729224

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghqfCjQgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgpvippgoM


Bot(s) for this bug's original alert(s):

android-nexus6
android-webview-nexus6
Cc: robertph...@google.com
Owner: robertph...@google.com

=== Auto-CCing suspected CL author robertphillips@google.com ===

Hi robertphillips@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Robert Phillips
  Commit : 8bf1f9ffcf4b0168a1a05399eb0ed4e5e04eab80
  Date   : Wed May 31 23:12:39 2017
  Subject: Disable deferred proxies for M60 branch

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : thread_times.key_silk_cases
  Metric       : thread_raster_cpu_time_per_frame/thread_raster_cpu_time_per_frame

Revision                             Result                    N
chromium@476248                      1.4378 +- 0.0331213       6      good
chromium@476281                      1.34594 +- 0.805666       6      good
chromium@476286                      1.44858 +- 0.0220671      6      good
chromium@476286,skia@8bf1f9ffcf      1.74201 +- 0.0282242      6      bad       <--
chromium@476286,skia@823103384c      1.75921 +- 0.0470462      6      bad
chromium@476286,skia@c5a073d031      1.74125 +- 0.0511149      6      bad
chromium@476287                      1.74814 +- 0.0476921      6      bad
chromium@476288                      1.75196 +- 0.0540053      6      bad
chromium@476290                      1.75966 +- 0.0675782      6      bad
chromium@476298                      1.72966 +- 0.0179458      6      bad
chromium@476314                      1.74226 +- 0.0625479      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_silk_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8977857184465390672

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6452082288099328


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

Comment 4 by m...@chromium.org, Jun 5 2017

Cc: -miu@google.com
Cc: kouhei@chromium.org
 Issue 730544  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jun 12 2017

Cc: alexclarke@chromium.org
 Issue 732316  has been merged into this issue.
The CL in question (https://skia-review.googlesource.com/c/18239/ (Disable deferred proxies for M60 branch)) has been reverted in:

https://skia-review.googlesource.com/c/19446/ (Re-enable deferred proxies in Chrome)

The revert rolled into Chrome on 6/12 in https://chromium-review.googlesource.com/c/531484/ at 478692.
All of the graphs with up to date data (as of 6/14) show the regression has been fixed by the revert.
Status: Fixed (was: Untriaged)

The revert seems to fix the Nexus5, 5x, and 6 key_silk_cases regressions.

The Nexus5 and 7v2 bots seems to have stopped getting updates for letmespellitoutforyou.com so I can't tell.

I don't know what is going on with the win7 & win10 LinkedIn bots which show no improvement.

Sign in to add a comment