//base replacement for content::BrowserThread::DeleteOnThread |
||||
Issue descriptionSince BrowserThread::FILE is being replaced with sequenced task runners we should probably think about a replacement for DeleteOnThread struct or at least refactoring the code that uses content::BrowserThread::DeleteOnThread<content::BrowserThread::FILE>
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98dee7702162992e0f0a605c09879f0bde1ce987 commit 98dee7702162992e0f0a605c09879f0bde1ce987 Author: gab <gab@chromium.org> Date: Wed Jun 07 15:49:03 2017 Improve documentation and tests for base::OnTaskRunnerDeleter. And cross-documentation from BrowserThread::DeleteOnThread (ref. crbug.com/729210 ). Modernized the tests while trying to make OnTaskRunnerDeleter work for RefCounted until I realized it wouldn't work as-is, still better than nothing for now and will help cleaner follow-up. BUG= 729210 Review-Url: https://codereview.chromium.org/2921343002 Cr-Commit-Position: refs/heads/master@{#477661} [modify] https://crrev.com/98dee7702162992e0f0a605c09879f0bde1ce987/base/sequenced_task_runner.h [modify] https://crrev.com/98dee7702162992e0f0a605c09879f0bde1ce987/base/sequenced_task_runner_unittest.cc [modify] https://crrev.com/98dee7702162992e0f0a605c09879f0bde1ce987/content/public/browser/browser_thread.h
,
Jun 7 2017
Highlighted existing replacement in code comments.
,
Jun 8 2017
Actually I'll keep this opened to track finding a mapping for Browser::DeleteOnThread's usage as a RefCountedTraits.
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ad840645e519cfc4ebb9af29ae479e29d296401 commit 0ad840645e519cfc4ebb9af29ae479e29d296401 Author: gab <gab@chromium.org> Date: Thu Jun 08 19:12:26 2017 Add cross-reference documentation about the forgotten RefCountedDeleteOnSequence. BUG= 729210 TBR=jam@chromium.org, danakj@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2927993002 Cr-Commit-Position: refs/heads/master@{#478047} [modify] https://crrev.com/0ad840645e519cfc4ebb9af29ae479e29d296401/base/sequenced_task_runner.h [modify] https://crrev.com/0ad840645e519cfc4ebb9af29ae479e29d296401/content/public/browser/browser_thread.h
,
Jun 8 2017
Turns out it existed but was well hidden... highlighting it in documentation. |
||||
►
Sign in to add a comment |
||||
Comment 1 by gab@chromium.org
, Jun 5 2017Status: Started (was: Untriaged)