Layer::Clone() in compositor/layer.cc does not clone layer_temperature_ property. |
||||||||
Issue descriptionSteps to repro: 1. Turn on night mode 2. Make a call to root_window->RecreateLayers() Observe that the layer color returns to normal but night mode is stuck at ON.
,
Jun 3 2017
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cd6f641ac975f67191db0297f34c227de70ae2f commit 7cd6f641ac975f67191db0297f34c227de70ae2f Author: afakhry <afakhry@chromium.org> Date: Mon Jun 05 18:09:48 2017 Cloning a ui::Layer should also clone its target temperature BUG= 729203 TEST=compositor_unittests --gtest_filter=LayerWithDelegateTest.Cloning Review-Url: https://codereview.chromium.org/2919183002 Cr-Commit-Position: refs/heads/master@{#477030} [modify] https://crrev.com/7cd6f641ac975f67191db0297f34c227de70ae2f/ui/compositor/layer.cc [modify] https://crrev.com/7cd6f641ac975f67191db0297f34c227de70ae2f/ui/compositor/layer.h [modify] https://crrev.com/7cd6f641ac975f67191db0297f34c227de70ae2f/ui/compositor/layer_unittest.cc
,
Jun 5 2017
,
Jun 5 2017
,
Jun 6 2017
Oops .. merge "request" not "approve".
,
Jun 6 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/944261aa897d6a63a55a95624cbdd8697bc32a13 commit 944261aa897d6a63a55a95624cbdd8697bc32a13 Author: Ahmed Fakhry <afakhry@google.com> Date: Tue Jun 06 18:24:19 2017 [Merge to M60] Cloning a ui::Layer should also clone its target temperature TBR=piman@chromium.org BUG= 729203 TEST=compositor_unittests --gtest_filter=LayerWithDelegateTest.Cloning Review-Url: https://codereview.chromium.org/2919183002 Cr-Original-Commit-Position: refs/heads/master@{#477030} Review-Url: https://codereview.chromium.org/2921353003 . Cr-Commit-Position: refs/branch-heads/3112@{#194} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/944261aa897d6a63a55a95624cbdd8697bc32a13/ui/compositor/layer.cc [modify] https://crrev.com/944261aa897d6a63a55a95624cbdd8697bc32a13/ui/compositor/layer.h [modify] https://crrev.com/944261aa897d6a63a55a95624cbdd8697bc32a13/ui/compositor/layer_unittest.cc
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by afakhry@chromium.org
, Jun 2 2017Status: Started (was: Assigned)