crash on clicking update icon in OOBE |
||||||
Issue descriptionChrome Version: 9588.0.0 OS: Chrome What steps will reproduce the problem? (1) Connect to cellular networks or tethered networks. (2) OOBE checks for updates and shows update icon in system tray. (3) Clicking the icon will crash the Chrome UI. What is the expected result? If over mobile data, the icon should not show in OOBE. What happens instead? The icon shows and crashes UI on clicking.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0320b2c46526df82b647a224a995642dfad79f7b commit 0320b2c46526df82b647a224a995642dfad79f7b Author: weidongg <weidongg@chromium.org> Date: Mon Jun 05 17:50:01 2017 Fix crash of update-over-cellular icon The CL disables update-over-cellular icon in system tray in locked and login screen, as the icon will bring user to settings page which is not available yet. BUG= 729202 Review-Url: https://codereview.chromium.org/2915383002 Cr-Commit-Position: refs/heads/master@{#477015} [modify] https://crrev.com/0320b2c46526df82b647a224a995642dfad79f7b/ash/system/update/tray_update.cc [modify] https://crrev.com/0320b2c46526df82b647a224a995642dfad79f7b/chrome/browser/chromeos/upgrade_detector_chromeos.cc
,
Jun 5 2017
,
Jun 5 2017
,
Jun 6 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5174f6d433bd20a07816d681d16af69cca3581c commit b5174f6d433bd20a07816d681d16af69cca3581c Author: Ahmed Fakhry <afakhry@google.com> Date: Tue Jun 06 18:40:32 2017 [Merge to M60] Fix crash of update-over-cellular icon The CL disables update-over-cellular icon in system tray in locked and login screen, as the icon will bring user to settings page which is not available yet. TBR=xiyuan@chromium.org,stevenjb@chromium.org,weidongg@chromium.org BUG= 729202 Review-Url: https://codereview.chromium.org/2915383002 Cr-Original-Commit-Position: refs/heads/master@{#477015} Review-Url: https://codereview.chromium.org/2925893002 . Cr-Commit-Position: refs/branch-heads/3112@{#195} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/b5174f6d433bd20a07816d681d16af69cca3581c/ash/system/update/tray_update.cc [modify] https://crrev.com/b5174f6d433bd20a07816d681d16af69cca3581c/chrome/browser/chromeos/upgrade_detector_chromeos.cc
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by weidongg@chromium.org
, Jun 2 2017