New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729197 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Omnibox suggestions dropdown text overflows the right edge of omnibox

Project Member Reported by tommycli@chromium.org, Jun 2 2017

Issue description

1. Use Mac Chrome. Enter a very long query string.
2. Observe that the suggestions can overflow the right-edge of the Omnibox.
3. This does not happen in Linux or Windows (views)
 
Screen Shot 2017-06-02 at 3.28.36 PM.png
546 KB View Download
Cc: groby@chromium.org pkasting@chromium.org mpear...@chromium.org jdonnelly@chromium.org
groby/jdonnelly:

The suggestions text isn't supposed to overflow past the right-edge of the actual Omnibox right?

It doesn't on Views.
Equivalent screenshot on Views shows that it cuts off at the width of the actual omnibox on the right side.
Screenshot from 2017-06-02 15:41:32.png
100 KB View Download
Labels: OS-Mac
I agree the Views behavior seems more appropriate. I'll leave it to the Mac team to triage.
Cc: shrike@chromium.org
+shrike@ who has implemented MD for Mac.
Cc: -shrike@chromium.org tommycli@chromium.org
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)
Cc: -tommycli@chromium.org shrike@chromium.org
Owner: tommycli@chromium.org
Version with fix here: https://codereview.chromium.org/2927193002/


Screen Shot 2017-06-08 at 2.40.40 PM.png
279 KB View Download
Per offline discussion, I'm sending a CL to shrike@ to review based on his suggested fix.
Status: Fixed (was: Assigned)
Labels: TE-Verified-M61 TE-Verified-61.0.3135.4
Tested this issue on Mac 10.12.5 using chrome dev # 61.0.3135.4 as per the steps mentioned in comment#0.

Observed that the suggestions are not getting overflowed to the right-edge of the Omnibox when user enter lengthy text which is more than the omnibox.
Hence adding TE Verified labels.

Please find the attached screencast for reference.
Thanks..!!

729197.mp4
1.3 MB View Download

Sign in to add a comment