Omnibox suggestions dropdown text overflows the right edge of omnibox |
|||||||
Issue description1. Use Mac Chrome. Enter a very long query string. 2. Observe that the suggestions can overflow the right-edge of the Omnibox. 3. This does not happen in Linux or Windows (views)
,
Jun 2 2017
Equivalent screenshot on Views shows that it cuts off at the width of the actual omnibox on the right side.
,
Jun 5 2017
I agree the Views behavior seems more appropriate. I'll leave it to the Mac team to triage.
,
Jun 8 2017
+shrike@ who has implemented MD for Mac.
,
Jun 8 2017
,
Jun 8 2017
Version with fix here: https://codereview.chromium.org/2927193002/
,
Jun 8 2017
Per offline discussion, I'm sending a CL to shrike@ to review based on his suggested fix.
,
Jun 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b56a5733a6ded284c245018071328dbb99aadb5 commit 7b56a5733a6ded284c245018071328dbb99aadb5 Author: tommycli <tommycli@chromium.org> Date: Mon Jun 12 22:53:40 2017 Omnibox UI: Create right-margin on Cocoa dropdown BUG= 729197 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2927193002 Cr-Commit-Position: refs/heads/master@{#478801} [modify] https://crrev.com/7b56a5733a6ded284c245018071328dbb99aadb5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h [modify] https://crrev.com/7b56a5733a6ded284c245018071328dbb99aadb5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm [modify] https://crrev.com/7b56a5733a6ded284c245018071328dbb99aadb5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h [modify] https://crrev.com/7b56a5733a6ded284c245018071328dbb99aadb5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm [modify] https://crrev.com/7b56a5733a6ded284c245018071328dbb99aadb5/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
,
Jun 12 2017
,
Jun 20 2017
Tested this issue on Mac 10.12.5 using chrome dev # 61.0.3135.4 as per the steps mentioned in comment#0. Observed that the suggestions are not getting overflowed to the right-edge of the Omnibox when user enter lengthy text which is more than the omnibox. Hence adding TE Verified labels. Please find the attached screencast for reference. Thanks..!! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tommycli@chromium.org
, Jun 2 2017