Shelf should not auto-unhide when vol up/down |
|||||
Issue descriptionIf the shelf is hidden (either as a shelf setting or an app going fullscreen), toggling the volume buttons should not bring up the entire shelf in addition to the volume chip UI.
,
Jun 2 2017
,
Jun 5 2017
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/593f82d4b2351c8f7a3eb4081839f8171ed04b36 commit 593f82d4b2351c8f7a3eb4081839f8171ed04b36 Author: Evan Stade <estade@chromium.org> Date: Mon Jun 05 22:07:28 2017 CrOS: Don't show auto-hidden shelf due to volume change. Bug: 729188 Change-Id: Ibaf8ff66036ccd5621586dc0e4795028512778a6 Reviewed-on: https://chromium-review.googlesource.com/523267 Reviewed-by: Terry Anderson <tdanderson@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#477094} [modify] https://crrev.com/593f82d4b2351c8f7a3eb4081839f8171ed04b36/ash/system/audio/tray_audio_unittest.cc [modify] https://crrev.com/593f82d4b2351c8f7a3eb4081839f8171ed04b36/ash/system/status_area_widget.cc
,
Jun 5 2017
this is present in m60. Do we care to merge it?
,
Jun 6 2017
If this were a recent regression I would say yes, a merge is warranted here. But it seems this is a long-standing bug (correct me if I am mistaken) so I'd suggest just leaving as-is.
,
Jun 6 2017
No need to merge from my perspective — would be great to have for M61 tho.
,
Jun 6 2017
Not that longstanding, I think it's a regression only a couple milestones old. The fix is in m61, so closing.
,
Jun 20 2017
9649.0.0, 61.0.3129.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jennschen@chromium.org
, Jun 2 2017