Issue metadata
Sign in to add a comment
|
Session length limit notification is not visible on login |
||||||||||||||||||||||
Issue descriptionChrome 61.0.3117, Chrome OS 9608 built from source I noticed this while working on some mustash UI refactoring for issue 712759 . I'm not sure if this is expected behavior or not. * Set up test DM server with go/dmstug * Set the user policy for SessionLengthLimit to 600000 ms (10 minutes) * Enterprise enroll a device using the test account in the doc * Sign in using the test account in the doc After login the system tray area shows [1] for the notification count, but no notification appears on screen. Opening the notification tray shows a notification about the session length limit. I expect either a notification to be visible on login (telling me the session is limited), or no notifications in the tray (until I get near the session expiration time). I think what is happening is that SystemTrayDelegateChromeOS is telling ash to update the TraySessionLengthLimit while the user is at the login screen, where notifications are suppressed, so the notification is created but does not show. bartfab, do you know if this is expected behavior? If so, feel free to close this. If not, do you know who might work on it? (I'm working on issue 712759 - I might be able to change it while I'm in the code.)
,
Jun 2 2017
Peppy/M60 observed notification is displayed after disconnecting network and connecting back. After offline mode...every time session length display is seen. M ChromeOS Chrome ARC Type Channel 60 9592.5.0 60.0.3112.10 (multiple) release dev
,
Jun 2 2017
Also, I am not seeing the "Exit Session" button in the attached images.
,
Jun 7 2017
Re #3: This is not a Public Session but a regular user session with a time limit. No "Exit session" button is expected. Re the original bug report: There should be a default-visible notification after login. If this does not show, we are dealing with a regression.
,
Jun 7 2017
This isn't a public session issue, so taking ivan off it. James, if you think you have a fix for this, please add it to your CL.
,
Jun 7 2017
I'll take a quick look later this week. (I'm WFH today and can't test this without a device.) I suspect we just need to defer showing the notification until login is complete and the user session is active. Aside: Is it possible to test enterprise policy features on Linux desktop with target_os="chromeos"?
,
Jun 7 2017
Typically yes. I am away from my desktop so don't recall the various flags - Ivan, what flags do you use to test public sessions on linux?
,
Jun 8 2017
This is how I run chrome locally: out/gn/chrome --login-manager --user-data-dir=/tmp/1 --login-profile=user --remote-debugging-port=2222 The login screen will be shown, and there you can do the enterprise enrollment by pressing CTRL+ALT+E.
,
Jun 8 2017
This only affects devices where WaitForInitialUserActivity is false, so it might not be common in the field. https://chromium-review.googlesource.com/528066 will fix it
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0a9e492fc43081ca6449bb3d57185d62130f59 commit 3c0a9e492fc43081ca6449bb3d57185d62130f59 Author: James Cook <jamescook@chromium.org> Date: Fri Jun 09 15:14:18 2017 chromeos: Show session length limit notification after login Previously we were attempting to show the notification at the login screen. Since notifications are suppressed at the login screen this meant that the notification was still hidden after login. Instead, defer showing the notification until after login. Bug: 729174 Test: added to ash_unittests Change-Id: I55fcb84a702a08f07108e4c57b7f9726cd52ed70 Reviewed-on: https://chromium-review.googlesource.com/528066 Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#478281} [modify] https://crrev.com/3c0a9e492fc43081ca6449bb3d57185d62130f59/ash/system/session/tray_session_length_limit.cc [modify] https://crrev.com/3c0a9e492fc43081ca6449bb3d57185d62130f59/ash/system/session/tray_session_length_limit.h [modify] https://crrev.com/3c0a9e492fc43081ca6449bb3d57185d62130f59/ash/system/session/tray_session_length_limit_unittest.cc
,
Jun 27 2017
Fixed a while ago.
,
Jul 6 2017
Could see session length in latest build on Peppy device. M ChromeOS Chrome ARC Type Channel 61 9718.0.0 61.0.3150.0 (multiple) release dev |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krishna...@chromium.org
, Jun 2 2017