New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729159 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Referrer not being properly recorded in tab sync for certain domains?

Project Member Reported by zea@chromium.org, Jun 2 2017

Issue description

Chrome Version       : 60.0.3112.10
OS Version: OS X 10.12.5

This doesn't seem to happen across all domains, but one where this consistently seems to happen is chromium.org.

Steps to repro:
Navigate to: https://dev.chromium.org/developers/design-documents
Click the first link to Multi-process Architecture

Check chrome://sync-internals and search for "Multi-process Architecture"

Expected:
Referrer field with "https://dev.chromium.org/developers/design-documents"

Actual:
Empty referrer

In addition, if you open the developer console in the Multi-process Architecture tab, and enter document.referrer, the proper referrer is shown. So the referrer is there, it's just not reaching tab sync for some reason.

This seems like it might be due to the logic around correcting referrer policy added here: https://codereview.chromium.org/869613006/diff/80001/components/sessions/content/content_serialized_navigation_driver.cc


 

Comment 1 by zea@chromium.org, Jun 19 2017

Status: Fixed (was: Started)
Fix landed in https://codereview.chromium.org/2921883003/.
Labels: TE-Verified-M61 TE-Verified-61.0.3135.4
Tested this issue on Mac 10.12.5 using chrome dev#61.0.3135.4 as per the steps mentioned in comment#0.

Observed that Referrer field displayed as  "https://dev.chromium.org/developers/design-documents" in console with 'document.referrer' command.As it is working as intended , adding TE Verified labels.

Please find the attached screencast for reference.
Thanks..!!

729159.mp4
4.5 MB View Download

Comment 3 by zea@chromium.org, Jun 20 2017

Labels: Merge-Request-60
Requesting merge for 60, as this affects other projects that consume synced data.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 20 2017

Labels: -Merge-Request-60 Merge-Reject-60 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M60 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment