Remove obsolete brillo related code from shill (e.g. code guarded under __BRILLO__ and __ANDROID__), which is no longer used, maintained, or even built.
Also maybe bring shill back to platform2?
Re #1: +1. that would be a nice follow-up task.
There's some discussion about moving various things from AOSP back to platform2 in issue 690513.
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/bc413f5e7398d429eecfa71b0a60c9e3fabf9e46 commit bc413f5e7398d429eecfa71b0a60c9e3fabf9e46 Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:14 2017 shill: remove Android.mk and shill.rc shill is no longer built for Android / Brillo. This CL removes the obsolete Android.mk and shill.rc. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: I7518acbe8f0ac234267cd069636fbaf4ceced833 Reviewed-on: https://chromium-review.googlesource.com/530056 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/25a275863142af602b182e1c2f3fe78ae441cef3/Android.mk [delete] https://crrev.com/25a275863142af602b182e1c2f3fe78ae441cef3/shill.rc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/f526cfa161f8fed1cfa409085ce5a8a47c884eb5 commit f526cfa161f8fed1cfa409085ce5a8a47c884eb5 Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:15 2017 shill: remove conditonal include of <dbus/service_constants.h> shill is no longer built for Android / Brillo. This CL removes the conditional include of <dbus/service_constants.h> for Android targets. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: I4a36288e671cbba8fe55cb915dac60122b9de5f0 Reviewed-on: https://chromium-review.googlesource.com/530057 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/ethernet/ethernet_eap_service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/ipconfig.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/error.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_cdma.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_third_party_vpn_dbus_adaptor.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_classic_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_modem_gsm_network_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_dbus_control.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_driver_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/third_party_vpn_driver.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/manager.h [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax_device_proxy_interface.h [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_universal.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/technology.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_gsm_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/connectivity_trial.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/binder/service_binder_adaptor.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcp_config.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_cdma.h [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/l2tp_ipsec_driver.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcp_properties_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/manager_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/eap_credentials.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcpv4_config_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcpv6_config.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/manager.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_universal_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_wimax_network_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax_service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/portal_detector.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_classic.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_endpoint.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcp_config_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/ipconfig_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/pppoe/pppoe_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/openvpn_driver.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/setup_wifi/main.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcpv6_config_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/device.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/metrics.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/profile.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/power_manager_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax_provider_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wake_on_wifi_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/service_property_change_test.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/power_manager.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/modem_info.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_provider_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_service_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/static_ip_parameters.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/openvpn_management_server_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax_provider.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/error_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_gsm.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_gsm.h [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/metrics_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcp_properties.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_cdma_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_wimax_manager_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/openvpn_driver_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wimax/wimax.h [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/openvpn_management_server.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_driver.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/tdls_manager.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_capability_universal_cdma.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wake_on_wifi.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/property_store_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/cellular_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/tdls_manager_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_wimax_device_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/binder/manager_binder_adaptor.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/eap_credentials_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_provider.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_modem_gsm_card_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/ephemeral_profile.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/static_ip_parameters_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dbus/chromeos_modem_cdma_proxy.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/default_profile_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/device_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/connection_tester.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/ethernet/ethernet_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/dhcp/dhcpv4_config.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/wifi/wifi_endpoint_unittest.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/default_profile.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/cellular/mock_cellular_service.cc [modify] https://crrev.com/f526cfa161f8fed1cfa409085ce5a8a47c884eb5/vpn/vpn_provider_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3 commit 973b8c400d0c069a58d7acb47fc68b74e0ddfdf3 Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:15 2017 shill: remove unnecessary '#if !defined(__ANDROID__)' guards shill is no longer built for Android / Brillo. This CL removes the unnecessary '#if !defined(__ANDROID__)' guards around Chrome OS specific code. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: Ia792dff4843db37e28bfa114de995a83ae370700 Reviewed-on: https://chromium-review.googlesource.com/530058 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3/shill_main.cc [modify] https://crrev.com/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3/process_manager_unittest.cc [modify] https://crrev.com/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3/process_manager.cc [modify] https://crrev.com/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3/dbus/chromeos_supplicant_interface_proxy.cc [modify] https://crrev.com/973b8c400d0c069a58d7acb47fc68b74e0ddfdf3/metrics.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/59420cb22a6c0b0b36f61e54fe7993d40df3d61e commit 59420cb22a6c0b0b36f61e54fe7993d40df3d61e Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:15 2017 shill: remove code guarded under '#if defined(__ANDROID__)' shill is no longer built for Android / Brillo. This CL removes the Android specific code that is guarded under '#if defined(__ANDROID__)'. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: Id29c5d4869c1d5480eaaa1911c734debb807de17 Reviewed-on: https://chromium-review.googlesource.com/530059 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/59420cb22a6c0b0b36f61e54fe7993d40df3d61e/connection_unittest.cc [modify] https://crrev.com/59420cb22a6c0b0b36f61e54fe7993d40df3d61e/connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62 commit 1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62 Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:15 2017 shill: remove code conditionally compiled for Android shill is no longer built for Android / Brillo. This CL removes the code that is conditionally compiled for Android. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: Ic4162fdb691e722be0e25418fce17d418062da7f Reviewed-on: https://chromium-review.googlesource.com/530060 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/dbus/chromeos_dbus_control.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/shill_config.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/dhcp/dhcp_provider.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/dhcp/dhcp_config.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/icmp_session.h [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/ethernet/ethernet_service.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/connection.h [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/icmp.h [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/connection_unittest.cc [modify] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/connection.cc
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/97ccc37594cfbca3ececc9f035039ffac14230d3 commit 97ccc37594cfbca3ececc9f035039ffac14230d3 Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:15 2017 shill: remove binder support shill is no longer built for Android / Brillo. This CL removes the binder support and leaves DBus as the only supported mechanism to interact with shill. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: Ib48a6d7b4fbcc01487483c71930fe1b82ef92828 Reviewed-on: https://chromium-review.googlesource.com/530061 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/android/system/connectivity/shill/IManager.aidl [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/error.h [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/error.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/android/system/connectivity/shill/IDevice.aidl [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/service_binder_service.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/binder_adaptor.cc [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/key_value_store.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/binder_control.h [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/scope_logger_unittest.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/android/system/connectivity/shill/IPropertyChangedCallback.aidl [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/device_binder_service.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/manager_binder_adaptor.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/device_binder_service.h [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/error_unittest.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/manager_binder_adaptor.cc [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/shill.gyp [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/daemon_task.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/service_binder_service.h [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/key_value_store.cc [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/scope_logger.cc [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/scope_logger.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/binder_adaptor.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/service_binder_adaptor.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/device_binder_adaptor.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/device_binder_adaptor.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/android/system/connectivity/shill/IService.aidl [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/manager_binder_service.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/manager_binder_service.h [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/binder_control.cc [modify] https://crrev.com/97ccc37594cfbca3ececc9f035039ffac14230d3/key_value_store_unittest.cc [delete] https://crrev.com/1d9ddaf3e8fc402a042e12b7bdbd17ba3ecdbe62/binder/service_binder_adaptor.h
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/7e8cc3a53d98377729aee5a78f919febf6e8f4ea commit 7e8cc3a53d98377729aee5a78f919febf6e8f4ea Author: Ben Chan <benchan@chromium.org> Date: Mon Jun 12 21:16:16 2017 shill: remove code conditionally compiled for Brillo shill is no longer built for Android / Brillo. This CL removes the code that is conditionally compiled for Brillo. BUG= chromium:729155 TEST=Remote trybot runs. Change-Id: Iaf45efb8c8504d5049ce2f73cf3a3f417a5e0976 Reviewed-on: https://chromium-review.googlesource.com/530062 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/manager_unittest.cc [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/dbus/chromeos_manager_dbus_adaptor.cc [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/mock_manager.h [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/dbus/chromeos_manager_dbus_adaptor_unittest.cc [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/manager.h [modify] https://crrev.com/7e8cc3a53d98377729aee5a78f919febf6e8f4ea/manager.cc
Comment 1 by jorgelo@chromium.org
, Jun 2 2017