New issue
Advanced search Search tips

Issue 729152 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Move the SelectedPaymentMethod metric to native.

Project Member Reported by se...@chromium.org, Jun 2 2017

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b28c319705d87e294b1a98068872b47e10e09cc3

commit b28c319705d87e294b1a98068872b47e10e09cc3
Author: sebsg <sebsg@chromium.org>
Date: Sat Jun 03 02:16:10 2017

[Payments] Move the SelectedPaymentMethod metric to native.

Bug:  729152 
Change-Id: If60943d6cb81122f43f5f5026f1d8c135b25e7aa
Reviewed-on: https://chromium-review.googlesource.com/522927
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476859}
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/chrome/browser/payments/android/journey_logger_android.h
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/components/payments/core/journey_logger.cc
[modify] https://crrev.com/b28c319705d87e294b1a98068872b47e10e09cc3/components/payments/core/journey_logger.h

Comment 2 by se...@chromium.org, Jun 3 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 4 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 5 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56b1cb57128374690df5792c7ae031e57a796ff5

commit 56b1cb57128374690df5792c7ae031e57a796ff5
Author: sebsg <sebsg@chromium.org>
Date: Mon Jun 05 13:36:56 2017

Merge-60 [Payments] Move the SelectedPaymentMethod metric to native.

Bug:  729152 
Change-Id: If60943d6cb81122f43f5f5026f1d8c135b25e7aa
Reviewed-on: https://chromium-review.googlesource.com/522927
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#476859}
Review-Url: https://codereview.chromium.org/2917343003 .
Cr-Commit-Position: refs/branch-heads/3112@{#145}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/chrome/browser/payments/android/journey_logger_android.h
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/components/payments/core/journey_logger.cc
[modify] https://crrev.com/56b1cb57128374690df5792c7ae031e57a796ff5/components/payments/core/journey_logger.h

Comment 5 by se...@chromium.org, Jun 5 2017

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment