New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729140 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Uncaught TypeError: a[Oa] is not a function

Reported by jsc...@gmail.com, Jun 2 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

Steps to reproduce the problem:
1. visit http://interactjs.io/
2. move your mouse outside of Canary browser window to right
3. error appears in console

What is the expected behavior?
no error in console

What went wrong?
have no idea, guessing Canary is not handling pointer events correctly but just a guess

Did this work before? Yes 58.0.3029.110 

Chrome version: 61.0.3117.0  Channel: n/a
OS Version: 6.3
Flash Version: 

There is no bug on 58.0.3029.110 the current production version
 
Cc: nzolghadr@chromium.org
Components: -Blink Blink>Input
NextAction: 2017-06-16
The code is dispatching a pointerover to the document element. This seems like an allowed upon thing. The interact.js code isn't liking that the target can be document. They are calling target.matches essentially expecting target is a Element but target is a Document which inherits from Node which doesn't have the matches function.

jsc456@ are you in contact with the author of this site and can you advise them to fix it?
Cc: dtapu...@chromium.org

Comment 3 by jsc...@gmail.com, Jun 2 2017

I'm not in contact but I can try reporting it to https://github.com/taye
However, this error does not exist in the current Chrome browser (nor any other browser that I can see) I use interact.js in a project which is how I found this error so we test this frequently. It just appeared in Canary.
Cc: ligim...@chromium.org
Labels: Needs-Triage-M60 Needs-Bisect

Comment 5 by ajha@chromium.org, Jun 5 2017

Cc: pbomm...@chromium.org abdulsyed@chromium.org
Labels: -Pri-2 -Needs-Bisect -Needs-Triage-M60 hasbisect-per-revision ReleaseBlock-Stable M-59 OS-Linux OS-Mac Pri-1
Owner: chaopeng@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on the latest canary(61.0.3119.0) on Windows-10,Mac OS 10.12.5 and Linux Ubuntu 14.04..

This is regressed in M-59.

Last good build: 59.0.3062.0
First bad build: 59.0.3063.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/05267be8219e262196306d78d7eade8083de7595..2275c1f6d1f074d065de4d0d1aef624f9fcefa66

chaopeng@: Could this be related to https://codereview.chromium.org/2784313002 

Note: Adding the stable blocker for M-59 as this is regressed in M-59 & just in case fix needs to be targeted for next stable(M-59) release or stable refresh thereafter. Feel free to remove the blocker if this should not be blocking.

Thank you!
Labels: -ReleaseBlock-Stable
Based on comment#1, I am removing stable blocker.
Cc: bokan@chromium.org

Comment 8 by bokan@chromium.org, Jun 5 2017

I think the difference is that we're sending mouse events occurring over a frame scrollbar to the #document now, whereas we didn't before. Firefox also does this so I think we're actually improving interop here, but strangely the error doesn't occur there. I can't actually get pointerover events to fire in Firefox at all, so perhaps they're not supported/working (MDN says they should though) and that's why the error isn't showing up?
As discussed I believe we should be sending these events to the document.documentElement chaopeng@ will prepare a patch.
Labels: Hotlist-Input-Dev

Comment 11 by jsc...@gmail.com, Jun 6 2017

Just updated to Chrome Version 59.0.3071.86 (Official Build) (64-bit) and console error now appears in production version. I'm guessing you already knew that but just in case.
Yup we have a plan to fix it in 60.
Status: Fixed (was: Assigned)

Comment 15 by jsc...@gmail.com, Jun 13 2017

Confirmed fixed for me at least. thank you!
The NextAction date has arrived: 2017-06-16
NextAction: ----

Sign in to add a comment