This CL which I should hopefully be able to land soon will upgrade Robolectric within Chromium to 3.4.2

https://chromium-review.googlesource.com/c/609371

I'm picking up the CL mikecase@ mentioned in #1.

Rebased & revised CL up: https://chromium-review.googlesource.com/c/chromium/src/+/709469

3.5 and 3.5.1 released over the past two weeks. I'll probably land the CL mentioned in #4 (as it's mostly ready) and then look at upgrading from there to 3.5.1.

I recently got bit by https://github.com/robolectric/robolectric/issues/2115, which is fixed in https://github.com/robolectric/robolectric/releases/tag/robolectric-3.3.2. It would be nice if we could update Robolectric sooner.

#6: the CL in #4 needs a couple of rebases and a prior CL to land but is otherwise ready.

Thanks! I'm trying that locally.

The DEPS stuff might be a little gnarly, beware.

Tried Robolectric 3.4.2, but sadly the issue about testing AsyncTasks is not fully fixed there. Revert the priority.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79bf00ad560f5eb18998655911a0610b545a3c7b

commit 79bf00ad560f5eb18998655911a0610b545a3c7b
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Nov 10 18:22:19 2017

[android] Update to Robolectric 3.4.2.

With Robolectric 3.4.2, we can nearly run vanilla, only requiring
the following modifications:
 - we need to have a stub impl of MavenDependencyResolver since there
   is no point to adding the third-party Maven jars to Chromium.
 - we need to have some files which are generated by Robolectric
   annotation processor during compile time. GN makes it
   difficult to use these auto-gen files during the build.

This also rolls findbugs to pick up a GN change required to expose a
JAR for 3.4.2.

Bug:  729135 
Change-Id: I3e80b532bd88ba6a40b64eb935a31f52cc20588f
Reviewed-on: https://chromium-review.googlesource.com/709469
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515606}
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/DEPS
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/base/android/junit/src/org/chromium/base/LogTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/build/cipd/android/android.ensure
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/compositor/animation/CompositorAnimatorTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/gcore/GoogleApiClientHelperTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/init/AsyncInitTaskRunnerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/installedapp/InstalledAppProviderTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationActionsUpdatedTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationFaviconTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerNotificationTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerServiceLifecycleTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationManagerThrottlerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTitleUpdatedTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/omnibox/geo/PlatformNetworksManagerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDirectoryManagerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/WebApkUtilsTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/chrome/android/webapk/test/src/org/chromium/webapk/test/WebApkTestHelper.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerGcmNetworkManagerTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerImplTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsClientTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/components/web_restrictions/browser/junit/src/org/chromium/components/webrestrictions/browser/WebRestrictionsContentProviderTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/device/geolocation/android/junit/src/org/chromium/device/geolocation/LocationProviderTest.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/testing/android/junit/java/src/org/chromium/testing/local/GNManifestFactory.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/BUILD.gn
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/README.chromium
[modify] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/cipd.yaml
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/processor/src/main/resources/META-INF/services/javax.annotation.processing.Processor
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/robolectric/src/main/java/org/robolectric/internal/dependency/MavenDependencyResolver.java
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/robolectric/src/main/resources/robolectric-version.properties
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/shadows/framework/src/main/resources/META-INF/services/org.robolectric.ShadowsAdapter
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/shadows/multidex/src/main/resources/META-INF/services/org.robolectric.internal.ShadowProvider
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/shadows/playservices/src/main/resources/META-INF/services/org.robolectric.internal.ShadowProvider
[add] https://crrev.com/79bf00ad560f5eb18998655911a0610b545a3c7b/third_party/robolectric/local/shadows/resources/META-INF/services/org.robolectric.internal.ShadowProvider

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81

commit e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Nov 30 23:35:22 2017

Roll Robolectric to 3.5.1.

Bug:  729135 
Change-Id: Ib8c512e675157d46c6009f53bc462c0d9511fbfe
Reviewed-on: https://chromium-review.googlesource.com/798641
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520746}
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/DEPS
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/build/cipd/android/android.ensure
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/chrome/android/junit/src/org/chromium/chrome/browser/background_task_scheduler/NativeBackgroundTaskTest.java
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerImplTest.java
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/components/background_task_scheduler/android/junit/src/org/chromium/components/background_task_scheduler/BackgroundTaskSchedulerPrefsTest.java
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/third_party/robolectric/BUILD.gn
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/third_party/robolectric/README.chromium
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/third_party/robolectric/cipd.yaml
[modify] https://crrev.com/e7f2d13349bf8d6c825c47c24fb5c1de4b5ecc81/third_party/robolectric/local/robolectric/src/main/resources/robolectric-version.properties