New issue
Advanced search Search tips

Issue 729115 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

When launching cbuildbot --buildbot, imply --debug

Project Member Reported by davidri...@chromium.org, Jun 2 2017

Issue description

If testing cbuildbot changes locally with --buildbot, --debug must be specified to ensure that it isn't treated as a production builder with bad things being done.

Example invocation:
  cbuildbot --debug --buildbot --nobootstrap --noreexec --buildroot <dir> <config>


Make this less error prone by having --buildbot imply --debug, and requiring the builders to say --nodebug to actually do damage.

Suitable for fixit or introductory bug.
 
Labels: Hotlist-Fixit
Owner: dgarr...@chromium.org
I've been trying to do some command line shuffling because of cbuildbot_launch. I'll see if I can work this in.
Status: Available (was: Untriaged)
To deploy this:

1) Add --nodebug (or whatever we call it), but ignore it.
2) Add new argument to recipe.
3) Start setting --debug if --nodebug isn't present.

Thinking about this again.... the original purpose of "--buildbot" was to indicate that a build was on a buildbot.

I think the problem is that people are being required to use "--buildbot" for local test builds.

Instead, we should remove the requirement to pass in "--buildbot" to do that, but building without "--buildbot" should imply "--debug".
I thought it's because cbuildbot --local and cbuildbot --buildbot --debug end up exercising different code paths.  cbuildbot --local is fine if you're wanting to build an image with some changes, cbuildbot --buildbot --debug is more useful if you're trying to make cbuildbot changes.
--local is actually a tryjob that uses your machine as the builder (does a full sync new a new directory, patches in changes, everything).

--buildbot just runs the build in the local checkout.

I think that if I create "cros tryjobs" ( crbug.com/735720 ), that will remove the normal use case for developers running "cbuildbot" if they aren't actually working on cbuildbot.

At that point it'll be fair to just run a build in the current checkout if you run "cbuildbot lumpy-paladin" with --debug implied. Then people won't need to use "--buildbot" for local testing at all, which will make me happier and be slightly more straight forward.

For tryjobs, the only way to set "--buildbot" with one of these two options, which strongly discourage random use.

  --production          This is a production build, NOT a test build. Confirm
                        with Chrome OS deputy before use.
  --pass-through PASSTHROUGH_RAW
                        Arguments to pass to cbuildbot. To be avoided.Confirm
                        with Chrome OS deputy before use.


I'll reshuffle the cbuildbot options to allow builds without --buildbot or --remote-tryjob after I finish removing tryjob launch support from it.

Status: Archived (was: Available)

Sign in to add a comment