When launching cbuildbot --buildbot, imply --debug |
|||
Issue descriptionIf testing cbuildbot changes locally with --buildbot, --debug must be specified to ensure that it isn't treated as a production builder with bad things being done. Example invocation: cbuildbot --debug --buildbot --nobootstrap --noreexec --buildroot <dir> <config> Make this less error prone by having --buildbot imply --debug, and requiring the builders to say --nodebug to actually do damage. Suitable for fixit or introductory bug.
,
Jun 14 2017
To deploy this: 1) Add --nodebug (or whatever we call it), but ignore it. 2) Add new argument to recipe. 3) Start setting --debug if --nodebug isn't present.
,
Jun 21 2017
Thinking about this again.... the original purpose of "--buildbot" was to indicate that a build was on a buildbot. I think the problem is that people are being required to use "--buildbot" for local test builds. Instead, we should remove the requirement to pass in "--buildbot" to do that, but building without "--buildbot" should imply "--debug".
,
Jun 21 2017
I thought it's because cbuildbot --local and cbuildbot --buildbot --debug end up exercising different code paths. cbuildbot --local is fine if you're wanting to build an image with some changes, cbuildbot --buildbot --debug is more useful if you're trying to make cbuildbot changes.
,
Jun 21 2017
--local is actually a tryjob that uses your machine as the builder (does a full sync new a new directory, patches in changes, everything). --buildbot just runs the build in the local checkout. I think that if I create "cros tryjobs" ( crbug.com/735720 ), that will remove the normal use case for developers running "cbuildbot" if they aren't actually working on cbuildbot. At that point it'll be fair to just run a build in the current checkout if you run "cbuildbot lumpy-paladin" with --debug implied. Then people won't need to use "--buildbot" for local testing at all, which will make me happier and be slightly more straight forward.
,
Aug 25 2017
For tryjobs, the only way to set "--buildbot" with one of these two options, which strongly discourage random use.
--production This is a production build, NOT a test build. Confirm
with Chrome OS deputy before use.
--pass-through PASSTHROUGH_RAW
Arguments to pass to cbuildbot. To be avoided.Confirm
with Chrome OS deputy before use.
,
Aug 25 2017
I'll reshuffle the cbuildbot options to allow builds without --buildbot or --remote-tryjob after I finish removing tryjob launch support from it.
,
Jan 5 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dgarr...@chromium.org
, Jun 2 2017Owner: dgarr...@chromium.org