[WebPayments] icons (pencils, back arrow) need focus/hover/press effects |
|||||||||||||
Issue descriptionTested on Mac; may apply on other platforms
,
Jun 6 2017
+estade in case he has seen a similar issue elsewhere
,
Jun 6 2017
https://rsolomakhin.github.io/pr, click "buy", then go to a subscreen and highlight the back arrow (vector icon). Should be highlighted and it is not on Mac. Tested to be working on Linux.
,
Jun 6 2017
The bug report being a bit bare, I'm not sure what the issue is or if I've seen it.
,
Jun 6 2017
On Mac Canary, you can try reproing the issue in #c3, thanks
,
Jun 6 2017
,
Jun 6 2017
I don't have a mac device. By "visually change", I take it you're talking about hover and press effects, i.e. ripples. I don't think ripples exist on mac. I don't know what the hover or press effects are expected there. Your best bet is to ask someone who works on that platform like shrike@.
,
Jun 6 2017
We also need these controls to visually indicate when they have tab-focus (e.g., a blue highlight). If the other interactions (i.e., ripples) don't yet exist on Mac, that's probably manageable, but there's a meaningful a11y and UX concern about focus behavior.
,
Jun 6 2017
ok. On Views, the pointer highlight and keyboard focus are usually the same effect (try alt+shift+t to see it on the toolbar buttons).
,
Jun 6 2017
,
Jun 6 2017
+shrike@ to cc per c#7
,
Jun 7 2017
+ellyjones@ Keyboard focus for accessibility works in MacViews. Note that by default on the Mac, not all controls are keyboard accessible - you have to enable that in the Shortcuts tab of the Keyboard pane in System Preferences (maybe that's the problem you're seeing). There is no ripple on the Mac, but the regular Harmony buttons do display hover and pressed effects in MacViews. If the back arrow button is not one of these standard buttons, and if hover/pressed is for some reason tied to ripples, that might explain why you don't see them. Hover/press will have to be decoupled from ripples in that case.
,
Jun 9 2017
We're using an ImageButton; from my digging I think it's an InkDropHighlight that causes the hover/focus behavior we see on other platforms, but we aren't really dealing with it directly in our code. So unless I'm misunderstanding something, this shouldn't be related to ripples.
,
Jun 9 2017
InkDropRipple and InkDropHighlight are part of the same framework so "ripple" is used loosely to talk about any kind of "InkDrop".
,
Jun 13 2017
OK, it looks like this is definitely going to involve some non-trivial work with painters that probably isn't justified by the severity of the UI issues for the current milestone. Releasing this for the time being.
,
Jun 19 2017
Assigning to the desktop PR owner to make sure this does not get lost.
,
Jun 20 2017
,
Jun 27 2017
,
Jul 27 2017
,
Apr 25 2018
This appears fixed on Mac Canary so closing as WontFix. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by ma...@chromium.org
, Jun 5 2017