New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729108 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug


Participants' hotlists:
Payments-Maintenance

Show other hotlists

Other hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

[WebPayments] icons (pencils, back arrow) need focus/hover/press effects

Project Member Reported by tmartino@chromium.org, Jun 2 2017

Issue description

Tested on Mac; may apply on other platforms
 

Comment 1 by ma...@chromium.org, Jun 5 2017

Labels: -Pri-3 Pri-2

Comment 2 by ma...@chromium.org, Jun 6 2017

Cc: est...@chromium.org
+estade in case he has seen a similar issue elsewhere

Comment 3 by ma...@chromium.org, Jun 6 2017

https://rsolomakhin.github.io/pr, click "buy", then go to a subscreen and highlight the back arrow (vector icon). Should be highlighted and it is not on Mac.

Tested to be working on Linux. 
The bug report being a bit bare, I'm not sure what the issue is or if I've seen it.

Comment 5 by ma...@chromium.org, Jun 6 2017

On Mac Canary, you can try reproing the issue in #c3, thanks

Comment 6 by ma...@chromium.org, Jun 6 2017

Screen Shot 2017-06-06 at 9.17.33 AM.png
26.0 KB View Download
Summary: [WebPayments] icons (pencils, back arrow) need hover/press effects (was: [WebPayments] Vector icons (pencils, back arrow) need to visually change when focused)
I don't have a mac device. By "visually change", I take it you're talking about hover and press effects, i.e. ripples. I don't think ripples exist on mac. I don't know what the hover or press effects are expected there. Your best bet is to ask someone who works on that platform like shrike@.
Summary: [WebPayments] icons (pencils, back arrow) need focus/hover/press effects (was: [WebPayments] icons (pencils, back arrow) need hover/press effects)
We also need these controls to visually indicate when they have tab-focus (e.g., a blue highlight). If the other interactions (i.e., ripples) don't yet exist on Mac, that's probably manageable, but there's a meaningful a11y and UX concern about focus behavior.
ok. On Views, the pointer highlight and keyboard focus are usually the same effect (try alt+shift+t to see it on the toolbar buttons).
Owner: tmartino@chromium.org
Status: Started (was: Available)
Cc: shrike@chromium.org
+shrike@ to cc per c#7
Cc: ellyjo...@chromium.org
+ellyjones@

Keyboard focus for accessibility works in MacViews. Note that by default on the Mac, not all controls are keyboard accessible - you have to enable that in the Shortcuts tab of the Keyboard pane in System Preferences (maybe that's the problem you're seeing).

There is no ripple on the Mac, but the regular Harmony buttons do display hover and pressed effects in MacViews. If the back arrow button is not one of these standard buttons, and if hover/pressed is for some reason tied to ripples, that might explain why you don't see them. Hover/press will have to be decoupled from ripples in that case.

We're using an ImageButton; from my digging I think it's an InkDropHighlight that causes the hover/focus behavior we see on other platforms, but we aren't really dealing with it directly in our code. So unless I'm misunderstanding something, this shouldn't be related to ripples.
InkDropRipple and InkDropHighlight are part of the same framework so "ripple" is used loosely to talk about any kind of "InkDrop".
Owner: ----
Status: Available (was: Started)
OK, it looks like this is definitely going to involve some non-trivial work with painters that probably isn't justified by the severity of the UI issues for the current milestone. Releasing this for the time being.
Owner: anthonyvd@chromium.org
Status: Assigned (was: Available)
Assigning to the desktop PR owner to make sure this does not get lost.
Labels: -M-60 M-61
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Labels: -M-61 M-62
Status: WontFix (was: Assigned)
This appears fixed on Mac Canary so closing as WontFix. 

Sign in to add a comment