New issue
Advanced search Search tips

Issue 729085 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Move the RequestedInformation metric to native.

Project Member Reported by se...@chromium.org, Jun 2 2017

Issue description

^^^
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0717c24ed883c304b597653409bd3a815dd5092c

commit 0717c24ed883c304b597653409bd3a815dd5092c
Author: sebsg <sebsg@chromium.org>
Date: Mon Jun 05 18:44:45 2017

[Payments] Move the RequestedInformation metric to native.

Bug:  729085 
Change-Id: Ie2ad1325bc1dc4837949ffc9b679f9063ccbd9b0
Reviewed-on: https://chromium-review.googlesource.com/522903
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477040}
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[delete] https://crrev.com/511a8c5e5b84e23f573d4b80c4a1050d4245b77d/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/java_sources.gni
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[delete] https://crrev.com/511a8c5e5b84e23f573d4b80c4a1050d4245b77d/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/chrome/browser/payments/android/journey_logger_android.h
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/components/payments/core/journey_logger.cc
[modify] https://crrev.com/0717c24ed883c304b597653409bd3a815dd5092c/components/payments/core/journey_logger.h

Comment 2 by se...@chromium.org, Jun 6 2017

Labels: Merge-Request-60
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 6 2017

Labels: -Merge-Request-60 Hotlist-Merge-Approved Merge-Approved-60
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks for the fix. 

Please confirm whether the fix is verified in canary. If yes, merge to 3112 branch ASAP.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2017

Labels: -merge-approved-60 merge-merged-3112
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01029cab15a68d6010514ff9ad12256dc49a579a

commit 01029cab15a68d6010514ff9ad12256dc49a579a
Author: sebsg <sebsg@chromium.org>
Date: Tue Jun 06 20:08:56 2017

Merge-60 [Payments] Move the RequestedInformation metric to native.

Bug:  729085 
Change-Id: Ie2ad1325bc1dc4837949ffc9b679f9063ccbd9b0
Reviewed-on: https://chromium-review.googlesource.com/522903
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#477040}
Review-Url: https://codereview.chromium.org/2923243003 .
Cr-Commit-Position: refs/branch-heads/3112@{#201}
Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897}

[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[delete] https://crrev.com/7d60b722a9b5742b03cf7d07a1b4eb53ff3a898e/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/java_sources.gni
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsAndFreeShippingTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndFreeShippingTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailAndPhoneTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestEmailTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java
[delete] https://crrev.com/7d60b722a9b5742b03cf7d07a1b4eb53ff3a898e/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsUnitTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameAndFreeShippingTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNameTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneAndFreeShippingTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPhoneTest.java
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/browser/payments/android/journey_logger_android.cc
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/chrome/browser/payments/android/journey_logger_android.h
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/components/payments/core/journey_logger.cc
[modify] https://crrev.com/01029cab15a68d6010514ff9ad12256dc49a579a/components/payments/core/journey_logger.h

Comment 6 by se...@chromium.org, Jun 6 2017

Status: Fixed (was: Started)
Cc: kkaluri@chromium.org
Labels: Needs-Feedback
sebsg@ Could you please help us with steps to verify this fix from TE end.

Thank You...

Comment 8 by se...@chromium.org, Jun 8 2017

Labels: -Needs-Feedback
Status: Verified (was: Fixed)
That's a code only change. If there is no behavior change, it means it worked :)

Thanks!
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment