New issue
Advanced search Search tips

Issue 729082 link

Starred by 2 users
Status: Fixed
Owner:
isandrk@chromium.org
Closed: Oct 2017
Cc:
pastarmovj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 689520



Sign in to add a comment

Stop using the FILE thread in CloudPolicyManager

Project Member Reported by gab@chromium.org, Jun 2 2017 
There's a TODO(joaodasilva) in there that it's merely using the FILE thread because ComponentCloudPolicyStore previously enforced thread-affinity by inheriting from base::NonThreadSafe. This is no longer the case (it now uses a SequenceChecker and is happy on sequences).

  // TODO(joaodasilva): Move the |file_task_runner_| to the blocking pool.
  // Currently it's not possible because the ComponentCloudPolicyStore is
  // NonThreadSafe and doesn't support getting calls from different threads.

Could you please migrate it to the TaskScheduler (using base::CreateSequencedTaskRunnerWithTraits() from post_task.h); as well as any other components/policy code that uses FILE thread or BlockingPool, thanks!

Comment 1 by ljusten@chromium.org, Jun 9 2017

Owner: ljusten@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by ljusten@chromium.org, Jun 9 2017

Labels: Enterprise-Triaged

Comment 4 by ljusten@chromium.org, Jun 29 2017

Owner: isandrk@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad98d2c716bf5347388a7c52281762bc2fdfc16e

commit ad98d2c716bf5347388a7c52281762bc2fdfc16e
Author: Ivan Sandrk <isandrk@google.com>
Date: Wed Aug 23 08:31:53 2017

Migrate CloudPolicyManager to use TaskScheduler

Removing use of FILE thread, replacing with SequencedTaskRunner.

Bug:  689520 , 729082 
Change-Id: Ia7fe12ba44dec0c107f4ddaf3f1e9b0f5aa55095
Reviewed-on: https://chromium-review.googlesource.com/612171
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496626}
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/policy/profile_policy_connector_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/BUILD.gn
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/cloud_policy_manager.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/cloud_policy_manager.h
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/user_cloud_policy_manager.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/user_cloud_policy_manager.h
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/cloud/user_cloud_policy_manager_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/config_dir_policy_loader_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/configuration_policy_provider_test.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/configuration_policy_provider_test.h
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/policy_loader_mac_unittest.cc
[modify] https://crrev.com/ad98d2c716bf5347388a7c52281762bc2fdfc16e/components/policy/core/common/policy_loader_win_unittest.cc

Comment 6 by isandrk@chromium.org, Oct 16 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment