New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729077 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

chrome_elf_unittests IAT hooking test (and many browser_tests) failing on LLD64 bot since May 16

Project Member Reported by r...@chromium.org, Jun 2 2017

Issue description

The failing test is HookTest.IATHook. I suspect the browser_tests fail for the same reason, and the IAT test will be the smaller thing to look at. The browser tests crash with this on the stack:
base::win::IATPatchFunction::PatchFromModule

Last green: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD64%20tester/builds/1843
First red: https://build.chromium.org/p/chromium.fyi/builders/CrWinClangLLD64%20tester/builds/1846

Good LLVM revision: 303157
Bad LLVM revision: 303527

This is basically the same window as  http://crbug.com/728726 , but I doubt it's the .def file parser change because this is x64, which doesn't have the same stdcall mangling issues that 32-bit x86 does.

I suspect this is LLD r303374, which merged the IAT and ILT.
 

Comment 1 by r...@chromium.org, Jun 2 2017

Owner: r...@chromium.org
I confirmed this was the IAT/ILT merging change, and I reverted it in r304584. Let's close this tomorrow if the bots cycle green.
Status: Assigned (was: Unconfirmed)

Comment 3 by r...@chromium.org, Jun 5 2017

Status: Verified (was: Assigned)
The LLD bots are green again.

Sign in to add a comment