Issue metadata
Sign in to add a comment
|
Layout Test css3/blending/background-blend-mode-gif-color-2.html is flaky on Mac 10.11 (retina) |
||||||||||||||||||||||||
Issue descriptionAs discussed offline, the test seems rather fragile, given that it renders an animated GIF and essentially takes a snapshot of that after a timeout of 400 ms. Would be cool to de-flake. CL that introduced test expectation: 1283be78a5b797b02f92acd254cefb7678267226 Recent Skia rolls: c3568295e5606b20908b6155fd3cd0052fdb53be b0c42d992117b916e04b60c20c7d275155f787ac 6dfadefe0e66c5d0f820d33dd1a8b273ad5258ee
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82cbd7f74a88f70002df19ef348a8b421a1c5c21 commit 82cbd7f74a88f70002df19ef348a8b421a1c5c21 Author: engedy <engedy@chromium.org> Date: Fri Jun 02 19:15:56 2017 Mark css3/blending/background-blend-mode-gif-color-2.html as flaky on Mac 10.11. BUG= 729075 TBR=fmalita@chromium.org Review-Url: https://codereview.chromium.org/2921953002 Cr-Commit-Position: refs/heads/master@{#476746} [modify] https://crrev.com/82cbd7f74a88f70002df19ef348a8b421a1c5c21/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 6 2017
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a66b861a749a056b6cfb9949f4cd0797d86f67e commit 3a66b861a749a056b6cfb9949f4cd0797d86f67e Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Jun 15 06:14:22 2017 sheriff: Supress blending/background-blend-mode-gif-color-2.html Failing on mac 10.11: https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28retina%29/16873 TBR=robertphillips@chromium.org NOTRY=true Bug: 729075 Change-Id: Ia81c90819448baa73bf11ec97e9472f46daa7bd9 Reviewed-on: https://chromium-review.googlesource.com/536717 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#479621} [modify] https://crrev.com/3a66b861a749a056b6cfb9949f4cd0797d86f67e/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24c9f587451ae73f0a3d826dccb362913fb2ddc6 commit 24c9f587451ae73f0a3d826dccb362913fb2ddc6 Author: Florin Malita <fmalita@chromium.org> Date: Wed Jun 21 01:44:53 2017 Deflake background-blend-mode-gif-color-2.html The test is attempting to catch the second frame of an animated GIF (2 x 400ms frames) using setTimeout(400). This is super-fragile. Refactor to use advanceImageAnimation() intead. BUG= chromium:734733 , chromium:729075 Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef Reviewed-on: https://chromium-review.googlesource.com/541037 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#481075} [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2-expected.png [modify] https://crrev.com/24c9f587451ae73f0a3d826dccb362913fb2ddc6/third_party/WebKit/LayoutTests/css3/blending/background-blend-mode-gif-color-2.html
,
Jun 21 2017
Florin (fmalita) has fixed this test in 734733! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by engedy@chromium.org
, Jun 2 2017