New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 729068 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Fullscreen in VR broken when FullscreenActivity is enabled

Project Member Reported by amp@chromium.org, Jun 2 2017

Issue description

Chrome Version: 61.0.3118.0+
OS: Android

What steps will reproduce the problem?
(1) Navigate to a site with a fullscreen button (m.youtube.com works, or permissions.site)
(2) Enter vr (insert device into daydream headset)
(3) Enter fullscreen (click on full screen button)

What is the expected result?

VR UX changes to fullscreen (content quad shows only fullscreen element and VR UI is hidden)

What happens instead?

VR is exited (or perhaps just hidden) and the 2D fullscreen activity gets shown instead.

This started showing up after FullscreenActivity was enabled by default: https://chromium-review.googlesource.com/519247
 

Comment 1 by amp@chromium.org, Jun 2 2017

If we can check if we are in VR before entering FullscreenActivity we should be fine: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java?l=223

But we don't really want to make 'inVr' something that web contents is aware of.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a721f49cac31e4294a8d1898aaf612042f5f18c

commit 1a721f49cac31e4294a8d1898aaf612042f5f18c
Author: amp <amp@chromium.org>
Date: Tue Jun 06 00:30:25 2017

[VrShell] FullscreenActivity is not supported when in VR.

BUG= 729068 

Review-Url: https://codereview.chromium.org/2921023002
Cr-Commit-Position: refs/heads/master@{#477132}

[modify] https://crrev.com/1a721f49cac31e4294a8d1898aaf612042f5f18c/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Is this fixed now? Should we track re-enabling in  issue 729583 ?

Comment 4 by amp@chromium.org, Jun 26 2017

Owner: amp@chromium.org
Status: Fixed (was: Untriaged)
Yes this is currently working.  Marking as fixed, the follow up will be in  issue 729583 .

Sign in to add a comment