New issue
Advanced search Search tips

Issue 729055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

possible unwrapped commit description, line > 75 chars?

Project Member Reported by semenzato@chromium.org, Jun 2 2017

Issue description


There are no lines greater than 75 characters in the commit description...


semenzato@luigi:~/.../third_party/kernel/v3.8$ repo upload .
Run hook scripts from https://chrome-internal.googlesource.com/chromeos/manifest-internal.git (yes/always/NO)? yes

Errors in PROJECT *chromiumos/third_party/kernel*!
    COMMIT 4d33f4d4:
        Description:
            >CHROMIUM: low_mem: make ram_vs_swap_weight configurable
            >
            >As a temporary fix to OOM kill deadlocks, we want to try to
            >avoid OOMs or at least reduce the number of occurrences.
            >So we make the ram_vs_weight parameter run-time configurable,
            >with two possible uses in mind: 1. leave as is (the default)
            >and 2. on specific devices, set it to infinity so that
            >available swap is completely ignored in the available memory
            >calculation.
            >
            >This also adds the "available" sysfs entry, so that chrome
            >doesn't have to duplicate the available memory calculations.
            >
            >BUG=chromium:727707
            >TEST=played around with sysfs
            >
            >Change-Id: I9f9391c07227200299f6bb570687dc883feca6cb
            >
            >
        Errors:
            * checkpatch.pl errors/warnings
            
            WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
            #23: 
             mm/low-mem-notify.c            | 59 ++++++++++++++++++++++++++++++++++++++----
            
            total: 0 errors, 1 warnings, 151 lines checked
            
            Your patch has style problems, please review.
            
            NOTE: Ignored message types: FILE_PATH_CHANGES GERRIT_CHANGE_ID
            
            NOTE: If any of the errors are false positives, please report
                  them to the maintainer, see CHECKPATCH in MAINTAINERS.
            


 
Components: -Build Infra>Client>ChromeOS>Build OS>Kernel
Status: Fixed (was: Untriaged)
if this is still failing, please link to an existing CL that broke

that said, this is a failure in the checkpatch.pl script which is part of the kernel

Sign in to add a comment