New issue
Advanced search Search tips

Issue 729053 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Task

Blocking:
issue 712530



Sign in to add a comment

Remove duplicate functions for checking if promo/holdback is allowed

Project Member Reported by tbansal@chromium.org, Jun 2 2017

Issue description

DataReductionProxyConfigValues provides two functions: promo_allowed() and holdback() for checking if promo is allowed and holdback is enabled, respectively. DataReductionProxyParams class also provides exactly similar functionality.

We should remove these two functions from DataReductionProxyConfigValues class to reduce confusion for callers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251

commit fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251
Author: tbansal <tbansal@chromium.org>
Date: Tue Jun 06 03:01:55 2017

Data Reduction Proxy: Remove duplicate functions

Data Reduction Proxy (DRP): Remove duplicate functions for checking if
promo/holdback is allowed from DataReductionProxyConfigValues.

The corresponding flags which were used by these methods have also
been removed.

Also, remove the enum TestDataReductionProxyParams::HasNames which
is only used in testing, and is not testing any production code.

BUG= 729053 , 729054 
TBR=lazyboy@chromium.org

Review-Url: https://codereview.chromium.org/2922663002
Cr-Commit-Position: refs/heads/master@{#477164}

[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/chrome/browser/renderer_context_menu/render_view_context_menu_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h
[modify] https://crrev.com/fbf8bb28d6cf83c4055ad5d85010a7c5f8a50251/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment